joomla-projects / com_localise Goto Github PK

• Add joomla-cms as a submodule
• Add the test that installs Joomla
• Add a test that installs com_localise

@puneet0191 I think this task could be done by you ^_^

Create system tests for packages view:
administrator/index.php?option=com_localise&view=packages

Note: leave this task for the end because the packages view is not yet finished

Create help screen for:
https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.languages.html

In translation views Icon button always appears even though icon does not appear because it's not needed.

en-GB is usually the main language for translating, it would be nice if we can add a button to Sync the en-GB language and get the latest version from Github at:

• in the installer: https://github.com/joomla/joomla-cms/tree/staging/installation/language
• the administrator: https://github.com/joomla/joomla-cms/tree/staging/administrator/language/en-GB
• and the frontend: https://github.com/joomla/joomla-cms/tree/staging/language/en-GB

I think the most important part for tomorrow would be to implement a nice way to use the Github Framework package here

link to text editor and to strings need to be more clear

We need this for plurals.
Already, the interface displays the strings which are present in the file edited but not in the reference file

Create this help page: administrator/index.php?option=com_localise&view=packages

https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.package.html

In translations view (administrator/index.php?option=com_localise&view=translations) replace current columns and icons with this structure:

Tag | Translation name | Translated | Storage / Path | Strings / Phrases | Author | Type | info

Tag: Language tag
Translated: Percentage of wokr done
Storage/Path: Path of the language file
Strings /Phrases: Number of strings language files contains
Author : Whose the author of the lnaguage file and it would be nice to include an icon if it's Joomla core
Type: Component, module, plugin, library...
Info: An icon with tooltip for extra information

PHP Fatal error: Class 'coding-standards_Sniffs_WhiteSpace_SemicolonSpacingSniff' not found in /home/travis/.phpenv/versions/5.3.27/pear/PHP/CodeSniffer.php on line 1053

In translations view (administrator/index.php?option=com_localise&view=translations) replace cog icon for translated column with translation percentage

Create the page and the test class for:
administrator/index.php?option=com_localise&view=languages

Issue at: administrator/index.php?option=com_localise&view=language&layout=edit&client=site&tag=

This description is not correct:

It should say something that explains that we are referring to this:
https://github.com/joomla-projects/translate-joomla#standard-iso-codes-for-naming-language-packages

When we create a new language, the main ini file xx-XX.ini (in admin and site) is not proposed to translation

We have to review this way of getting client:
https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/controllers/language.php#L75-L92

Also check the tag later.

Create system tests for administrator/index.php?option=com_localise&view=translations

We need to find a solution for this: #19 (comment)

• Add xx-XX.finder_cli.ini which does not follow "normal" file names.
• Allow creation/editing of the xx-XX.localise.php, by adding it to the view and letting copy from reference in a codemirror editable instance.
• Allow creation/editing of the xx-XX.css, by adding it to the view in a codemirror editable instance.
• Allow, when making a core pack, adding some stuff in the media folder (calendar for Farsi is a good exemple)

All the file headers should look like:

<?php
/**
 * @package     Com_Localise
 * @subpackage XXX
 *
 * @copyright   Copyright (C) 2005 - 2014 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('_JEXEC') or die;

Where XXX can be: controller, model...

I am not exactly sure what is going wrong but it does not work. There are no JS errors.

index.php?option=com_localise&view=translation&layout=edit

Clicking on the bing button should automatically translate the sentence.

Currently the first load of com_localise starts processes all the .ini causing very poor performance. In some servers you get timeouts.

We need to study the current component and find a solution that makes it more performant. Maybe the solution could be an AJAX view that processes step by step all the things that needs to be done.

Clicking the help button does not return any help info

http://help.joomla.org/proxy/index.php?option=com_help&keyref=Help33:JHELP_COMPONENTS_com_localise_OPTIONS

There are several files and folders starting by "--"

I haven't check what does it means but much probably we are not using it and can be removed. See this examples:

https://github.com/joomla-projects/com_localise/tree/develop/administrator/components/com_localise/models

I've seen in a few places new JObject - we should switch to using JRegistry in several of those places.

Com_localise reads the date of the packages:

The problem is that when the date in the XML is not in american format it causes a crash in com_localise. To reproduce try to modify the creation date in the .XML manifest file of a language package and then make com_localise to read it. We need to make com_localise able to read a wrong date without chrashing. Later on the user can fix the date using this screen:

When accessing translations view (administrator/index.php?option=com_localise&view=translations) 3rd party icon is appearing in core language files.

at 14m50s in the video we see the languages list and also the translation list, they have a colour for every status:

green => translated,
orange => translated but warning because the origin and translated are the same
red => is not tranlsated or is wrong

I suggest that we create a legend at the top of the screen that describes what the color does

Create https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.packages.html

There is a delete button before every element in the "languages list":

But as the normal Joomla toolbar, I suggest to create a delete button in toolbar:

Create help screen for:
https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.language.html

It would be awesome if you @zanardigit or @puneet0191 could create here: https://github.com/joomla-projects/com_localise/tree/develop/tests/system a readme.md file that explains step by step how to run the tests. Something like we have at http://docs.joomla.org/Running_Automated_Tests_for_the_Joomla_CMS but smaller, just with a few steps to set up.

Issue at: administrator/index.php?option=com_localise&view=languages

When I click on removing a language:

I get this:

Right now the folder structure for the SQL files is not good, please refactor the component so it follows the standard folder structure:

/ component / admin / sql / install / mysql /
and
/ component / admin / sql / updates / mysql /

remember to update the XML manifest ^_^

If impossible to edit them in com_localise, these files should also be included in the package by browsing when package making.
The css is used to replace the main font in back-end for readability (Arabic)
The js concern Calendar. See Persian pack.

To display the comments is necessary. It was never implemented.
As well, no way to uncomment some strings

I have create package using sh build.sh file and tried to install packages/com_localise.zip
Installed successfully but after installing found error below.
Did I forget something?

There is still some uses of JRequests, needs to be moved to JInput https://github.com/joomla-projects/com_localise/search?q=JRequest&ref=cmdform&type=Code

We have this in the options of the component:

This is used to show the suggested string by Bing translator:

So if I create the French translation I will probably translate from the original en-GB files. However if I'm doing the French Canadian I will probably want to set the "reference language" as the fr-FR.

The question is: can we set "reference language" foreach language instead of setting it in the component configuration. That will allow us to have:

• French from france with reference language as English
• French canadian with reference language as French from France

Right we can't only do:

• French from france with reference language as English
• French canadian with reference language as Engiish

Because we can only set one general "reference language"

Create help screen for https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.translations.html

view: administrator/index.php?option=com_localise&view=translations

Review the current status of icons in the "Icons" at translations screen and report the issues that needs to be fixed

related to #94

If you generate the package you will get this:

It generates a language.localise.php empty file

Also the XML is empty:

In some models I saw that component is wrongly populating model state. Example:

https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/models/downloadpackage.php#L29-L30

To populate the state we should be using something like this:

$name = $this->getUserStateFromRequest($this->_context . '.name', 'name');

Then we can probably remove the getForm() method that is double checking the data in session.

Some ini files are displayed as not existing in reference language although they are.
Example in site: com_messages

It looks like this is due to the fact that there is no com_messages in front-end

As it is now, one can edit the reference language and get this error;

Error

RecursiveDirectoryIterator::_construct(/language): failed to open dir: No such file or directory
( ! ) Warning: constant(): Couldn't find constant LOCALISEPATH in ROOT/administrator/components/com_localise/models/translation.php on line 558

I think we just should not let edit the reference language.
What you think? PR would be quite easy.

Create help screen for translation: https://github.com/joomla-projects/com_localise/blob/develop/administrator/components/com_localise/help/en-GB/screen.translation.html

page: administrator/index.php?option=com_localise&view=translation

When We try to Delete a Language, We are getting an error messages like this

This tool will generate the language packages from the files in the system

Currently we have this view: administrator/index.php?option=com_localise&view=packages

The goal of this view is to allow us to generate a language package, right now is not working well but it shouds allow us to:

• Generate a language package oncluding only language files for SITE
• Generate a language package oncluding only language files for ADMIN
• Generate a language package oncluding only language files for SITE & ADMIN

See comment of Jean Marie below

I think we can stop using JObject (see https://github.com/joomla-projects/com_localise/search?q=JObject&ref=cmdform) and use a StdClass instead, isn't it?

@gunjanpatel or @wilsonge are any of you interested in taking this task?

Thanks

This task consist in work together between @gibilogic and @puneet0191 to create the base classes to use https://github.com/facebook/php-webdriver library instead of current Nearsoft based Joomla classes (https://github.com/joomla/joomla-cms/tree/staging/tests/system/webdriver see (SeleniumClient)