joomla-projects / cli-update Goto Github PK

Is it notIs not it better to exclude core extensions in the response of these methods?

• getUpdateIds
• getUpdates
• getAllExtensions
• infoInstalledVersions

They will anyway be updated with the Core.

Last update was 10 months ago, but local testing appears to be working.

I'd like to contribute. One immediate change I'd make is to compare the update version with the current version and skip if they match (maybe with a force re-install option). Right now it appears that when an update is requested, it's performed if needed or not.

Hi

I noticed this issue when using this to update from Joomla 3.7.4 to 3.8.1.

The error message was...
Error displaying the error page: Class 'JDocument' not found: Class 'JExtensionHelper' not found

Which I found a good thread about on...
joomla/joomla-cms#18316

I'll try and code up a fix.

We are literally removing support in 3.5.0 from updating via JInstaller because of the ordering the update is done in and you are about to reintroduce it with this script.....

When updating this way/through Extension Manager the following process happens:

• Extract package to tmp location
• Look for extension script, if it exists load it into memory and if it has a preflight method, trigger that
• Copy all the new files into place
• Update the extensions table's database row
• Run any SQL schema updates
• If the extension script has an update method, trigger that
• Cleanup from the update routine
• If the extension script has a postflight method, trigger that

In the update component, it's more like this

• Copy all the new files into place from a standalone script
• Loop back into Joomla (now running the new version's code in full)
• Load the extension script into memory, trigger preflight if it exists (it doesn't right now)
• Update the extensions table's database row
• Run any SQL schema updates
• Trigger update method in extension script if it exists (it does)
• Cleanup from the update routine
• Trigger postflight method in extension script if it exists (it doesn't right now)

The important thing being is the postflight is called with the new versions code rather than the old versions code.....

If you keep the current code as is the Core Updates are going to go badly badly wrong......

New features I planned to insert:

• Get list of extensions with state enabled, disabled or both
• Get state of single extension (enabled/disabled)
• Set state of single extension to enabled or disabled

#1 TODO

Priorise extensions before core