yibin wants bitchass greeks on his stats per se

delta of the opening price and the current price in dollar amount

The repository is tagged with v2 versions but go mod doesn't reflect this. Pulling for v2 of this package responds with an error:

$ go get github.com/jonwho/go-iex/v2
go: finding github.com/jonwho/go-iex/v2 v2.6.0
go: github.com/jonwho/go-iex/[email protected]: go.mod has non-.../v2 module path "github.com/jonwho/go-iex" (and .../v2/go.mod does not exist) at revision v2.6.0
go: error loading module requirements

Also, is go1.13 a strict requirement for this package? Would dropping to go1.11 be ok? Some deployments such as Google Cloud Functions for Go only support up to 1.11.6, and AppEngine only supports 1.11 and 1.12.

Would you be up to reconsider the GPL-3.0 license this package is currently shipped with? The linking clause in the license is somewhat of a restriction, especially within Go programs, for commercial use cases.

MIT, ISC, or BSD-3 would be good candidates to switch to!

using a bummy free account

can mock responses for paywalled endpoints then update tests

mock-iex is outdated. needs reflect iexcloud requests now

From https://iextrading.com/developer/docs/#chart

// .../1d

[
{
"date": "20171215"
"minute": "09:30",
"label": "09:30 AM",
"high": 143.98,
"low": 143.775,
"average": 143.889,
"volume": 3070,
"notional": 441740.275,
"numberOfTrades": 20,
"marktHigh": 143.98,
"marketLow": 143.775,
"marketAverage": 143.889,
"marketVolume": 3070,
"marketNotional": 441740.275,
"marketNumberOfTrades": 20,
"open": 143.98,
"close": 143.775,
"marktOpen": 143.98,
"marketClose": 143.775,
"changeOverTime": -0.0039,
"marketChangeOverTime": -0.004
} // , { ... }
]

// .../3m

[
{
"date": "2017-04-03",
"open": 143.1192,
"high": 143.5275,
"low": 142.4619,
"close": 143.1092,
"volume": 19985714,
"unadjustedClose": 143.7,
"unadjustedVolume": 19985714,
"change": 0.039835,
"changePercent": 0.028,
"vwap": 143.0507,
"label": "Apr 03, 17",
"changeOverTime": -0.0039
} // , { ... }
]

currently every VCR recording will overwrite all yamls. causes commit history to be quite bloated

probably update recorder to be a command that accepts flags for which recordings

double check that VCR pkg first to see if it does this already

can move to .mod/.sum file mgmt

do something like this https://yourbasic.org/golang/iota/

update func args afterwards to match consts

user can wrap calls with own context or api can add backoff strat for client

dont stop full test run on breaking assertion

want a full run so can use CI service later on

this will require mocks.

for different times of the day the api will return different values

mock these requests

accepting parameters as an interface feels clunky

define parameters struct per request

type BatchRequestParams struct {
    Types string `url:"types,omitempty"`
    Range string `url:"range,omitempty"
    Last int `url:"last,omitempty"
}