jonshaffer / angular-data-table Goto Github PK

Setup gulp task, devDependencies, any items related to getting protractor working within project

previously dynamically changing grouping was fixed, however, you cant remove the groups. would need a button added to remove groups in grouping demo(s)

Demo's, templates have no linting associated - would be helpful for development.

As it stands multi-column sorting happens in the order of which they were last sorted, but is not distinguishable in the UI. There should be some way of displaying that to the user.

Add feature allowing a sub-table per rows

Specifications:

Waiting on collaboration, likely not needed or can be solved in another way

Added: angular, jasmine, protractor, airbnb-base configs/plugins

There currently exists no demo for a table loaded with previously created options, data.

Should also have protractor tests created to verify functionality.

• allow it to be in another template?
• add column ordering
• add option for decluding column from management
• add pinning?

The codebase currently sits at under 14% code coverage, while 95% + would be ideal.

The configurations currently allow very vague source maps that could use enhancing.

Unit tests could benefit from helpers to cut down the amount of boilerplate required for specs.

initial proposed structure of this option:

sorting: {
  type: 'multiple' || 'single' (default: 'multiple'),
  modifierActive: true || false (default: true)
}

multiple + true means shift+click will clear sorting and only sort by current column being clicked
single + true means shift+click will keep existing sort and add on current column being clicked

Describe what each option is doing in detail, with dependencies, defaults, etc

When you hover a cell popover works as expected, but you can't select or interact with content due to it disappearing after the cursor leaves the cell.

This issue also exists when directive compiles before its parent directives have set widths

Notion: Development and production builds should be done in webpack instead of systemjs, gulp, and rollup.

This allows the development side of this repository to be much more manageable.

Scroll height is set by the table, and when using grouping + adding rows it does not accurately update the height until an action is taken on opening/closing groups.

Demo: http://codepen.io/properjon/full/dNbOyP

Repro steps:

1. Open demo
2. Scroll
3. Toggle group
4. Scrolling fixed

In the source file, scrollbarv and "row number（$row.$$index or $index）" cannot be used at the same time

TODO: write description

Header checkbox(es) not updating when .push'ing all data items to selected array, or when .splice'ing items from a full array

http://codepen.io/bensgroi/pen/MJpzzN

Add an example to the example website

You can currently set sortable on each column, but not on the table itself.

I haven't looked into the code yet, but I assume the virtual repeat is rendering a bit more rows than can be visible at once. Usually, this is done to avoid flickering and make the v-scroll experience more fluid; I haven't verified if this is the case, though. It appears, however, that when scrolling quickly and reaching the bottom of the scroll container, these padding rows are still present and blank.

David-dm badges, use http://img.shields.io/david/ instead

http://codepen.io/gabrielgeo/pen/KmRQMV

Have a tree grid that has a single page. Update dataset to have multiple pages. Scroll to other pages. Change dataset back to a dataset that only has 1 page. The grid is stuck in a blank state where it can't render rows because it is on page 2 when only 1 exists.

The variables options.paging.offset does not propagate downward into the data-table controllers at all. Furthermore, pretty much nothing propagates down correctly due to all these custom watchers. The entire component set does not use any angular data propagation at all instead relying on custom watchers.

How do I programmatically change the page? I have created a fork of this component and added custom events to the pager.controller, body.controller, datatable.controller. Nothing works.

Goals:

• Have E2E tests for all core functionality
• Create E2E tests designated *.e2e.js for directives focusing on the functionality they implement

Move angular-data-table to npm package import for source referenced by CodePen/Examples

Right now gh-pages branch is not updated as often, or as pervasive with demos, as the demo/ folder in master. It would be nice to couple them, potentially with gulp release to build to a docs folder.

Idea: Utilize CodePen post's, APIs to manage demo code within git

Update gulp test for protractor, add to npm test script

Add a exclude/ignore to this script in gulpfile

virtual paging should be integrated into the project so that it can be checked against the functionality with the rest of the table

Sorting doesn't work on virtual paging demo:
http://codepen.io/properjon/pen/kkqdyK

I could not found it on examples or wiki, if someone point me on the right direction i can document it in the wiki

As stated, if there are multiple tables on one page, horizontally scrolling any one table will scroll the headers on all visible tables.

To test, open demos/perf.html. Resize the columns on the first table such that one of the column overflows to the right. This enables the horizontal scroll bar. Using this to scroll, you can scroll across the headers on all tables.

Step 1: Normal table with resized columns. The second table does not resize as expected.

Step 2: Scrolling the horizontal scroll, also scrolls the second table.

It would be great if you could update compiler config so output file "dataTable.js" would not be minified.

Thanks for your work!

I don't think this works with Angular 1.6

I get over 51 errors now... 'Cannot set property 'scrollBarWidth' of undefined'
...
'Cannot read property columns of undefined'
...

The only thing I did was upgrade from Angular 1.4 to Angular 1.6
[Also checked for an updated version of this data-table]

Thanks!

Hover in and out of the tooltip rapidly to reproduce

Make all CodePen demos use release files from latest master on this fork

When scrolling quickly through the table the row classes are not being updated correctly onto the DOM; i.e., there will be two consecutive 'dt-row-odd's. This is not a big issue unless one overrides the background color styles for alternating row colors- then it becomes blatantly apparent. Looking more closely it appears to be related to rows that are only partially visible. It never happens to a block of rows in the center.

I'll look into this a bit later. I see a few different possibilities that could be the issues.

Speaking on another note; I work for a small team that will probably be using this component and there are a few outstanding issues that we (I) would like to fix- I forked the repo and will push some pull requests against it at some point.

By default, multiple column sorting is turned on, so if one column is sorted, clicking on another column header adds a secondary sort to the table. It exists in options.sortType but that isn't documented anywhere.

All breaking changes to defaults, options should be associated and discussed in this issue.

I was briefly trying to use the comparator function on the column configuration objects. I noticed that sorting was not working correctly for columns that were non_numeric and attaching my comparison (comparator) function had no effect. Looking into the code where the comparator is referenced I was unable to find any explicit use of the function (it's only used for a flag). There appear to be two bugs here (or I am using this incorrectly- if so please correct me)

1: comparator field on column definition object does not get triggered when present
2: sorting text columns does not cause any resorting to occur.

When adding rows to a table, it does not resort the items if the table is set to sort on the UI side.

Demo: http://codepen.io/properjon/full/dNbOyP

Repro steps in demo:

1. Open 2010
2. Click 'Add Rows'

Example:

1. See CodePen below
2. Go to last page
3. Move cursor over space below last row

http://codepen.io/bensgroi/pen/zNqyKb