jonathan435 / business-clocks-charts Goto Github PK

When using the PercentGoals property, if one wants to represent a value, say 25% the setter would expect 0.25 while the getter will give 25. There is a factor of 100 discrepancy.

In your demo, you programmatically set the background color of the form or canvas to black which conveniently makes the percent of the Goals Clock very visible.

You did not consider that other applications may have a different palette with a lighter background color. In such cases your default and apparently immutable text foreground color (for the percent) being white makes it very difficult to see.

It would, therefore, be advisable to expose the property to change the foreground color of the text. Now, if the library code was available I would have done it myself. I would probably have to look for another library :(

I suppose that happens because you use a panel inside of your control. When one sets a property like the cut line color for example, it is not updated in the visual until the user calls RefreshClock(). You should take care of that automatically in the setter property (as per good design practices).

In your demo if you use the default value of the last parameter of CarClock constructor (or set it to false) then the demo will throw a NullReferenceException on setting the Location property of CarClock.ClockPanel

There is no documentation that indicates which properties can be used to accomplish a certain look. If you want people to use the library you should consider their time is also precious, they want to get it working ASAP and then if needed delve into the code.

Even when the Animate property is false, there is an annoying visible flicker on the Inner Color when the RefreshClock method is called.

There is no source of the library to produce one that matches the .NET version one uses in a project. Mine vary a lot and this only has 4.5.2 and something else.

Since it is not very productive to work blindly as in the demo app, I was hoping to drop either of the 3 controls onto my windows forms and from there modify the properties, rather than creating it at runtime and having to guess where it should be placed, etc.

I tried to put the DLL into the Toolbox but VS.2017 says there are no components there that can be placed on the toolbox.