Improper resolution of referenced subschema about ex_json_schema HOT 6 CLOSED

Yes, that definitely looks wrong. I think the official test suite now has a lot more tests around relative refs and how they should be resolved. Back when I implemented the ref logic there wasn't much to go on. I will try and come up with a fix this week, and maybe update the test suite to cover all the expected ref behaviors.

from ex_json_schema.

Great, thanks a lot! I can offer to test any changes against my current project if that would be of any help for your.

from ex_json_schema.

Ok, that one was bit trickier to fix than I expected, but I found a whole bunch of other bugs around ref resolution in the process. I have to make a few final changes and then I will release a fixed version later this week.

from ex_json_schema.

Great, thanks a lot! Looking forward to the new version!

from ex_json_schema.

I released the ref handling fix as version 0.6.0, but it turns out that the Signal-K schema isn't a valid draft 4 schema:

** (ExJsonSchema.Schema.InvalidSchemaError) schema did not pass validation against its meta-schema: [%ExJsonSchema.Validator.Error{error: %ExJsonSchema.Validator.Error.Type{actual: "array", expected: ["object"]}, path: "#/definitions/chargerQualities/properties/allOf"}]

I verified with other validator implementations and they all come to the same result. The schema in https://signalk.org/specification/1.0.0/schemas/groups/electrical.json tries to use allOf in a property definition context and that doesn't work. According to the spec, allOf is treated as a normal property in that context and property definitions have to be objects.

from ex_json_schema.

First of all thanks a lot for the update. I can confirm / reproduce the schema did not pass validation against its meta-schema error and I'll address this upstream with the signal-k developers.

from ex_json_schema.