Support custom formats for non-string types about ex_json_schema HOT 5 CLOSED

Or maybe instead we should think about a more generic approach for plugging in custom validations?

from ex_json_schema.

Hey, in theory what you're trying to do could be achieved using "multipleOf": 0.001 as described here: https://stackoverflow.com/questions/27260587/decimal-precision-in-json-schema

Unfortunately we're dealing with floats here with unknown precision. A lot of JSON Schema libs have trouble with this for the same reasons. So for example:

iex(18)> ExJsonSchema.Validator.valid?(%{"type" => "number", "multipleOf" => 0.01}, 147.41)
true
iex(19)> ExJsonSchema.Validator.valid?(%{"type" => "number", "multipleOf" => 0.01}, 147.42)
false

Maybe you can have a look at the multipleOf implementation first and try to make it work with reasonable precision? It can never be entirely accurate unless we use a proper decimal representation, but maybe we can make it Good Enough™️ with floats?

from ex_json_schema.

I think it makes sense to use decimal to implement this, otherwise this is going to be an everlasting cat and mouse game. Opened #66 for that.

from ex_json_schema.

Yes, good call 👍

from ex_json_schema.

Thanks for accepting the PR! I think this solves our immediate needs.

from ex_json_schema.