jonahkayizzi / portfolio Goto Github PK

You did great work! 👋

Highlights: 💪
Good PR description
Good commit description
Very neat and clear code in html and CSS files

It was hard for us to find errors in your project, however, we can give you these recommendations:

Recommendations:
Add PR Title
You can add comments to the html, for non technical people using (<-- your comment here -->) inside the document
You should try to avoid using capital letters in the name of the images
Try to use verbs in past tense when commit

Good job!!! 🏅

@JonahKayizzi
Great 👍 job so far.
Form validation works perfectly well.
But there is something you can do to improve your code

I think you should write a function for the following line of code
https://github.com/JonahKayizzi/Portfolio/pull/13/files#diff-f5eb33e8d29f62f273061b550c9ca989e596e8012e12da73ffc3de735a8d7a81R21-R25
and call the function in each form input field event listener.

Please check out the online version of my portfolio 😉

• Clean-looking project
• Scaling works smoothly
• Button transitions work

Optional:

• Kindly fix the middle scroll-down button, right now the transition does not really fit with the others 😸
• Please consider adjusting the comment text-area transition so that the environment does not move 👍