joho / awesome-code-review Goto Github PK

I think there could be a section with code reviewing checklists.

• https://github.com/isocpp/CppCoreGuidelines
• https://github.com/code-review-checklists/java-concurrency

These two that know about.

https://www.infoq.com/articles/API-Design-Joshua-Bloch can also be considered an API design checklist.

Perhaps some style guides can also be included, such as https://github.com/airbnb/javascript.

Hi @joho! I have a link to a YouTube video that I’d love to add to this repo, but I’m not sure where to put it. Maybe there can a Video category?

Thanks for the post. Please can you recommend any code review tools library (paid or free) that I can integrate on my website??

Right now we've got two open PRs for non-english readers:

• #39 adds a spanish translation of the readme including titles and descriptions but linking to the original english works
• #35 adds a section for podcasts in portuguese within the existing readme

I'll do a bit of research into what's "best practice" for multilingual awesome lists before merging or rejecting either of the PRs.

Absent any research i'm inclined to keep the main list in english, but maybe have alternative language files that link to language specific content (ie. readme.es.md is written in spanish and links to spanish language content) and possibly appoint per lang maintainers as I can't judge the quality of the content myself.

If anyone has alternative ideas please share them in this thread.

The first two links under the Talks section on the README.md file are broken.

The urls should be:

• RubyConf 2017: Code Reviews: Honesty, Kindness, Inspiration: Pick Three
• RubyConf 2017: Goldilocks and the Three Code Reviews

There's quite a few automated code review or continuous inspection tools missing from this list:

• SonarQube
• Code Climate
• Codebeat
• Codacy
• DeepScan
• DeepCode
• Scrutinizer

The only one currently listed is Sider, and the list is long enough that I'd argue it warrants a separate section.

I've also set up an example repo (with a focus on JS) to compare the results of the tools.

That is ok if I add a podcast or more contents portuguese?

This is a basic question, but... what counts as "code review" in the contribution graph in Github? Is it making comments on code or committing to code? I don't really understand the concept.