johnwarne / reddit-top-rss Goto Github PK

View Code? Open in Web Editor NEW

163.0 163.0 13.0 1.58 MB

Generate RSS feeds for specified subreddits with score thresholds

License: MIT License

PHP 76.36% JavaScript 11.31% Dockerfile 0.48% SCSS 11.85%

reddit-top-rss's People

Contributors

Stargazers

Watchers

Forkers

semieway svpn sal-xyz chewingbever victor4x josephdefazio sethpyle376 sylph520 apraxx whateveritworks cronocide

reddit-top-rss's Issues

Reddit gallery images are not displayed

Posts that contains gallery images (multiple Reddit images) do not show the images.

Feature request: Make it possible to use old.reddit.com for the base rss api

I would love to have my rss items link to old.reddit.com. This is done automatically by reddit if you just do old.reddit.com/r/sub.rss instead of www.reddit.com/r/sub.rss

Having a checkbox I could select when setting up the feed that makes the feed use old.reddit.com would probably be my preferred way of having this implemented

Error sort-and-filter.php

Hi,
i have an issue and hope you still maintain this ;)
i don't know if there were some changes on reddit side or if my server had a hiccup

Here are the logs from docker:

2023-05-04 19:57:24,863 INFO supervisord started with pid 1
 2023-05-04 19:57:25,869 INFO spawned: 'nginx' with pid 7
 2023-05-04 19:57:25,876 INFO spawned: 'php-fpm' with pid 8
 [04-May-2023 19:57:25] NOTICE: fpm is running, pid 8
 [04-May-2023 19:57:25] NOTICE: ready to handle connections
 2023-05-04 19:57:26,957 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
 2023-05-04 19:57:26,958 INFO success: php-fpm entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
 192.168.16.28 - - [04/May/2023:19:58:00 +0000] "GET / HTTP/1.1" 200 1177 "-" "Mozilla/5.0 (Windows NT 10.0; rv:112.0) Gecko/20100101 Firefox/112.0" "172.20.0.1" 0.009 0.008 . -
 192.168.16.28 - - [04/May/2023:19:58:01 +0000] "GET /postlist.php?subreddit=worldnews&score=&threshold=&averagePostsPerDay= HTTP/1.1" 200 105 "https://reddit-top-rss.mysite.org/?subreddit=worldnews" "Mozilla/5.0 (Windows NT 10.0; rv:112.0) Gecko/20100101 Firefox/112.0" "172.20.0.1" 0.126 0.124 . -
 192.168.16.28 - - [04/May/2023:19:58:10 +0000] "GET /postlist.php?subreddit=worldnews&score=1&threshold=&averagePostsPerDay= HTTP/1.1" 200 105 "https://reddit-top-rss.mysite.org/?subreddit=worldnews&score=1" "Mozilla/5.0 (Windows NT 10.0; rv:112.0) Gecko/20100101 Firefox/112.0" "172.20.0.1" 0.074 0.072 . -
 NOTICE: PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25
 NOTICE: PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25
 NOTICE: PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25
 NOTICE: PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25
 NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, null given in /var/www/html/sort-and-filter.php:25
 Stack trace:
 #0 /var/www/html/rss.php(17): include()
 #1 /var/www/html/index.php(25): include('...')
 #2 {main}
   thrown in /var/www/html/sort-and-filter.php on line 25
 192.168.16.22 - - [04/May/2023:19:58:25 +0000] "GET /?subreddit=technology&averagePostsPerDay=2&view=rss HTTP/1.1" 500 5 "-" "Mozilla/5.0 (compatible; Miniflux/2.0.43; +https://miniflux.app)" "-" 0.096 0.096 . -
 2023/05/04 19:58:25 [error] 9#9: *11 FastCGI sent in stderr: "PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 25PHP message: PHP Warning:  Trying to access array offset
on value of type null in /var/www/html/sort-and-filter.php on line 25PHP message: PHP Fatal error:  Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, null given in /var/www/html/sort-and-filter.php:25
 Stack trace:
 #0 /var/www/html/rss.php(17): include()
 #1 /var/www/html/index.php(25): include('...')
 #2 {main}
   thrown in /var/www/html/sort-and-filter.php on line 25" while reading response header from upstream, client: 192.168.16.22, server: _, request: "GET /?subreddit=technology&averagePostsPerDay=2&view=rss HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "reddit-top-rss:8080"

i tried to make some sense of it and look if i could fix it myself but i dont know if it's a backend change of the json or something else?

hope you see this and thanks for providing this tool as long as you did

Doesn't work on quarantined subreddits

Is there any way to work around this limitation?

You can try r/russia for an example.

And here is the doc from reddit:
https://support.reddithelp.com/hc/en-us/articles/360043069012-Quarantined-Subreddits

Filter NSFW

Is it possible to filter out NSFW posts so that it only shows SFW posts

https://reddit-top-rss.herokuapp.com - Application Error

It seems like the application has an error on heroku.

Do you plan to fix the error, or is it just no longer being maintained?

As much as I enjoy the free instance, I can understand if the latter is the case, just wanted to check before thinking of a solution.

feature request, comments count?

it would be good idea to have comments count filter?
for example any technical sub, I want to read feed only when it has been commented

thanks again

Found XSS Reflected Injection vulnerabilities

Hello,
I was searching for vulnerabilities in code and I came across your repository. I have noticed that you do not perform any kind of Input sanitization in your code when selecting the "score", and while there isn't any kind of risk because the purpose of this webpage is just generating RSS feeds without any kind of data being persisted, it would be a good idea to adopt the practice of sanitizing your inputs. Every developer should know that user-manipulated input is always dangerous.

The following XSS injection was found on your webpage:

and this is the poc url that you also can access:

http://80.211.128.73:5000/?subreddit=news&score=2134"><script>alert("This happens when you do not perform any kind of input sanitization :)")</script>

Videos show a broken video thumbnail

Will this project still work after the API changes?

Reddit is changing its API. Will it affect this project?

Feature request: Multiple subreddits and custom feed URL's

Hello,

Thank you for this.

It would be more amazing if we could:

Update it so that you can add multiple feeds, as many as you want, and it will merge them into one feed to monitor all your fav subs.
Add custom feed URL's like search feeds with different sorting parameters for example adding this to the combined feed:

https://www.reddit.com/r/startups/search.rss?q=saas&restrict_sr=1&sr_nsfw=&sort=new

Considering updating a fork with this functions, would this be complex, how many hours for a dev? (I am not a dev).

Thanks!

User profile

Hi,

Sorry if this has been asked before. Can we also have rss for users profile? For example u/user (Reddit.com/u/user)

Found XSS Reflected Injection vulnerabilities

Hello, I was searching for simple vulnerabilities in code and I came across your repository. I have noticed that you do not perform any kind of Input sanitization in your code, and while there isn't any kind of risk because the purpose of this webpage is just generating RSS feeds without any kind of data being persisted, it would be a good idea to adopt the practice of sanitizing your inputs. Every developer should know that user-manipulated input is always dangerous.

The following XSS injection was found on your webpage:

The picture above shows you the result of injecting code, and the code causing this is the following line
echo "<div class='alert alert-warning' role='alert'>/r/" . $_GET["subreddit"] . " is not a valid subreddit</div>"; in your postlist.php file.

I would suggest the use of Regular expression or the following PHP functions
strip_tags
htmlentities
htmlspecialchars

Goodbye!

Link element may contain relative URL

I came across an item where the link element contains a relative URL instead of an absolute URL:

<item>
  <title>Stadia has officially gone 40 days without a new game announcement/release, feature update, or real community update. It has been out for 69 days. (self.Stadia)</title>
  <link>/r/Stadia/comments/eusxgc/stadia_has_officially_gone_40_days_without_a_new/</link>
  <guid isPermaLink="false">https://www.reddit.com/r/Games/comments/euum86/stadia_has_officially_gone_40_days_without_a_new/</guid>
  <description><![CDATA[<p><a href='https://www.reddit.com/r/Games/comments/euum86/stadia_has_officially_gone_40_days_without_a_new/'>Post permalink</a> </p>]]></description>
  <pubDate>Mon, 27 Jan 2020 21:19:27 +0000</pubDate>
</item>

Feedly seems to be able to deal with this, but I don't think it's valid. Or it could just be a bug in my own reader.

Thanks for the great project!

Can you make it so that it only fetches images

Support Docker IPv4

I don't have a ton of time atm to dig into this but I believe if I disabled IPv6 and try to startup a docker container it will fail. This is an issue with Nginx where it needs some kind of configuration change.

This is the error message I see when I disabled IPv6 on my Ubuntu server and ran your image

2024/02/20 15:54:29 [emerg] 7#7: socket() [::]:8080 failed (97: Address family not supported by protocol)
2024-02-20 15:54:29,760 INFO exited: nginx (exit status 1; not expected)
2024-02-20 15:54:29,761 INFO gave up: nginx entered FATAL state, too many start retries too quickly

I ran into a similar issue when running the nginx-proxy-manager image. But they had an environment param I could pass. I think a similar param might be needed and passed to nginx to support something similar (their codebase).

I did have this image working fine before I disabled IPv6, so that should eliminate some possible other issues.

Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 56

I am running reddit-top-rss as a local docker container. A couple days ago, it stopped working and now feeds showed up in my RSS reader.

I read about the authorization using the client_id and client_secret and added that to my container as described in the README.

However, it does still not work.

The docker logs show the following:

172.17.0.1 - - [06/Jun/2023:06:12:39 +0000] "GET /?subreddit=fantasy&threshold=50&view=rss HTTP/1.1" 500 5 "-" "Newsboat/2.31.0 (Linux x86_64)" "-" 0.393 0.393 . -
2023/06/06 06:12:39 [error] 9#9: *13170 FastCGI sent in stderr: "PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 56PHP message: PHP Warning:  Trying to access array offset on value of type null in /var/www/html/sort-and-filter.php on line 56PHP message: PHP Fatal error:  Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array, null given in /var/www/html/sort-and-filter.php:56
Stack trace:
#0 /var/www/html/rss.php(17): include()
#1 /var/www/html/index.php(25): include('...')
#2 {main}
  thrown in /var/www/html/sort-and-filter.php on line 56" while reading response header from upstream, client: 172.17.0.1, server: _, request: "GET /?subreddit=fantasy&threshold=50&view=rss HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "localhost:9999"

Visiting the website shows this:

Did I do something wrong with the credentials, or has reddit-to-rss stopped working?

Error with new oauth

Thanks for improving this app.

I provided my docker the credentials for the new app via env
It seems to work but outputs this error.

 [11-May-2023 09:36:42] NOTICE: fpm is running, pid 9
 [11-May-2023 09:36:42] NOTICE: ready to handle connections
 NOTICE: PHP message: PHP Warning:  include(auth.php): Failed to open stream: No such file or directory in /var/www/html/index.php on line 11
 NOTICE: PHP message: PHP Warning:  include(): Failed opening 'auth.php' for inclusion (include_path='.:/usr/share/php8') in /var/www/html/index.php on line 11
 2023/05/11 09:36:52 [error] 12#12: *1 FastCGI sent in stderr: "PHP message: PHP Warning:  include(auth.php): Failed to open stream: No such file or directory in /var/www/html/index.php on line 11PHP message: PHP Warning:  include(): Failed opening 'auth.php' for inclusion (include_path='.:/usr/share/php8') in /var/www/html/index.php on line 11" while reading response header from upstream, client: 192.168.16.28, server: _, request: "GET /?subreddit=worldnews&averagePostsPerDay=4 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "reddit-top-rss.mysite.org"
 NOTICE: PHP message: PHP Warning:  include(auth.php): Failed to open stream: No such file or directory in /var/www/html/postlist.php on line 11
 NOTICE: PHP message: PHP Warning:  include(): Failed opening 'auth.php' for inclusion (include_path='.:/usr/share/php8') in /var/www/html/postlist.php on line 11
 NOTICE: PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 23
 NOTICE: PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 26
 NOTICE: PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 32
 NOTICE: PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 41
 NOTICE: PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/postlist.php on line 41
 2023/05/11 09:36:54 [error] 12#12: *3 FastCGI sent in stderr: "PHP message: PHP Warning:  include(auth.php): Failed to open stream: No such file or directory in /var/www/html/postlist.php on line 11PHP message: PHP Warning:  include(): Failed opening 'auth.php' for inclusion (include_path='.:/usr/share/php8') in /var/www/html/postlist.php on line 11PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 23PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 26PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 32PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/sort-and-filter.php on line 41PHP message: PHP Warning:  Undefined variable $accessToken in /var/www/html/postlist.php on line 41" while reading response header from upstream, client: 192.168.16.28, server: _, request: "GET /postlist.php?subreddit=worldnews&score=&threshold=&averagePostsPerDay=4 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "reddit-top-rss.mysite.org", referrer: "https://reddit-top-rss.mysite.org/?subreddit=worldnews&averagePostsPerDay=4"

its a new container and manually built as per the git master dockerfile

edit: checked your dockerhub image same thing

Big thanks!

Best,
Markus