johanla0 / rails-repository-code-analyzer Goto Github PK
View Code? Open in Web Editor NEWHexlet - Rails program - Repository Quality Analyzer service
Home Page: https://rails-project-66.onrender.com/
Hexlet - Rails program - Repository Quality Analyzer service
Home Page: https://rails-project-66.onrender.com/
Rename resource as we're creating not webhook but a check
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/config/routes.rb#L9
Create webhook itself
Replace link to commit while the check is in process - it's not valid currently.
This one is not used
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/views/layouts/shared/_menu_admin.html.slim
Get rid of fetch_suitable_client_repos
callback
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/controllers/web/repositories_controller.rb#L5
Create repository asynchronously
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/controllers/web/repositories_controller.rb#L29
Don't need authorize
for true policy
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/controllers/web/repositories_controller.rb#L8
Look for Check
in a repository scope
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/controllers/web/repositories/checks_controller.rb#L8
Create Check
before creating a job
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/controllers/web/repositories/checks_controller.rb#L16
Test if user is logged off
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/test/controllers/web/auth_controller_test.rb#L37
Don't use stub_request
in tests - prefer ApplicationContainer
.
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/test/controllers/web/repositories_controller_test.rb#L34
Test at least one attribute of repository received from github API
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/test/controllers/web/repositories_controller_test.rb
Use repository from fixtures which has no checks - easier to test everything was created correctly
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/test/controllers/web/repositories/checks_controller_test.rb#L20
Add test for api
Use aasm human_state
helper instead and update locales
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/helpers/model_helper.rb#L13
directory_path
is used only in services - no place for it in presenter
https://github.com/johanla0/rails-project-66/tree/8d4035c38572cb43a14794bc1c53ce6563625d31/app/presenters
Better use helper method check_enabled?
or something
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/views/web/repositories/show.html.slim#L10-L11
Don't need instances here for both classes - no need to initialize new ones
https://github.com/johanla0/rails-project-66/tree/8d4035c38572cb43a14794bc1c53ce6563625d31/app/lib/linter
Remove default_configs
, use from the project directory
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/lib/linter/linter.rb
Missing --no-eslintrc
for eslint
Move to app/jobs
https://github.com/johanla0/rails-project-66/tree/8d4035c38572cb43a14794bc1c53ce6563625d31/app/sidekiq
Remove sidekiq because Hexlet autotest does not support redis
commit_hash
for less questions - seems like it is used for belongs_to
relations shallow_clone
- Git.clone creates all directories before cloning, url is already stored in git_url
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/services/repository_service.rb#L13
also don't need to clone it in tests - use stub instead
Rethink UserService
naming
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/services/user_service.rb
Do we need to return this if it's not used?
https://github.com/johanla0/rails-project-66/blob/8d4035c38572cb43a14794bc1c53ce6563625d31/app/services/repository/check_service.rb#L10
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.