johanhelsing / bevy_web_asset Goto Github PK

Currently, if the response is a http error, we just blindly pass the payload on to the asset loader, which will most likely fail.

On certain http error codes it probably makes sense to retry, on others it probably makes sense to log a warning/error and return and AssetIoError.

Split from: #4
Related to: #6

It's happening because the filesystem watcher implementation in bevy tries to downcast the asset io to FileAssetIO. Since we're wrapping it, that downcast fails, and nothing happens.

Bevy issue: bevyengine/bevy#1414

Bevy 0.12 adds native support for remote asset sources, making most code here redundant.
Will bevy_web_asset become a legacy crate, or will it provide boilerplate implementations for http/https?

app.register_asset_source("http", ..);
app.register_asset_source("https", ..);

Hi, do you mind adding a permissive license like MIT / Apache?

I've got a weird double image fetching error going on locally. Building for wasm and testing in firefox on M1.

Hey, here's the screenshot of what I'm seeing.

Essentially it looks like there's a second request getting kicked off that will always take any url and append .meta on the end.
someurl.jpg -> someurl.jpg.meta

Bug

I am getting this error when trying to load more than one web asset.

ERROR bevy_asset::server: Encountered an I/O error while loading asset: unexpected status code 500 while loading https://example.png: Head byte length should be less than 8kb

This error is misleading and the head byte length is less than 8kb. There is an issue on the surf repo http-rs/surf#289 which points to it being a bug in http-rs/async-h1's DDOS protection but from a cursory glance, I can't see the cause. I could create an issue downstream but its looking unmaintained.

Reproduction

It was reproducing 100% of the time in my project and I think I boiled it down to it happening when:

1. First, a request has to be made to a web server that 404s but has a body to it.
2. Next, a request to an asset over 8kb will result in this error.

Since asset meta checks 404s on every asset, this bug happens every time I load more than one asset. I noticed that this bug does not happen on all web servers and I am assuming this is something to do with the size of the 404 response. For testing purposes, I noticed images from Apple's website also return 404s with html bodies when .meta is appended to the end of an image URL and can be used to reproduce this bug.

Workarounds

1. Use .insert_resource(AssetMetaCheck::Never) to avoid 404s. I cannot use this one because I am using processed mode for local assets.
2. Compile bevy_web_asset with surf = { features = [ "curl-client" ] }

When the user has a poor connection and the server can't be reached, we just warn and report the asset as AssetIoError::NotFound.

However, it probably makes sense to retry if we couldn't reach the server.

We should probably add a loop inside WebAssetIo::load_path to retry in those cases.

Split from: #4

The unwrap here is causing a panic occasionally:

panicked at 'called `Result::unwrap()` on an `Err` value: JsValue(TypeError: NetworkError when attempting to fetch resource.
)', /home/gilescope/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_web_asset-0.4.0/src/web_asset_io.rs:26:83

Got: panicked at 'IoTaskPool resource not found'.

Anyone seen this error before? I'm on bevy 0.7 at the moment (waiting a bit longer to upgrade to 0.8).

Is there some additional setup to do for wasm given things are a tad different on the browser?

isahc is not easily usable on android, because it always uses openssl and doesn't have a published version that can opt-out of that (sagebind/isahc#199).

I read #18 (comment), but it's not clear to me why isahc was preferred over surf, when both appear to not have the issue with loading some urls.

I can do the work and switch back to surf (and set it up so it works with rustls) if that is ok with y'all

When trying to load an Image in a WASM game following error is output to the console

WARN C:\Users\Jay\.cargo\registry\src\github.com-1ecc6299db9ec823\bevy_asset-0.9.1\src\asset_server.rs:454 encountered an error while loading an asset: Error reading image file https://i.pinimg.com/originals/b5/41/b3/b541b339d5fee0af74e95d3fe7bbf038.png: failed to load an image: Format error decoding Png: Unexpected end of data before image end., this is an error in `bevy_render`.

I've been working with this library using an image pulled from S3 as a testing URL.

• https://s3.johanhelsing.studio/dump/favicon.png

This image parses in just fine, but I'm running into an asset path parsing error when sending in a url that contains a port.

• http://localhost:4566/dev/1705716540539.jpeg

Ideally, I'd like to use pre-signed urls from S3 and that would look something like this.

• http://localhost:4566/dev/1705716540539.jpeg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=%2F20240120%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240120T025447Z&X-Amz-Expires=900&X-Amz-Signature=842061632a1275fb44cc436afa46865112917e8382b74701823048107c3aca50&X-Amz-SignedHeaders=host&x-id=GetObject

The error I'm seeing so far looks like this.

/bevy_asset-0.12.1/src/path.rs:104:37: called `Result::unwrap()` on an `Err` value: InvalidSourceSyntax

I tracked down where I think this is being thrown to the while loop that parses paths looking for :. Since there is a second : in the url containing a path, it seems to throw that InvalidSourceSyntax error.

    while let Some((index, char)) = chars.next() {
          match char {
              ':' => {
                  let (_, char) = chars
                      .next()
                      .ok_or(ParseAssetPathError::InvalidSourceSyntax)?;
                  if char != '/' {
                      return Err(ParseAssetPathError::InvalidSourceSyntax);
                  }
                  let (index, char) = chars
                      .next()
                      .ok_or(ParseAssetPathError::InvalidSourceSyntax)?;
                  if char != '/' {
                      return Err(ParseAssetPathError::InvalidSourceSyntax);
                  }
                  source_range = Some(0..index - 2);
                  path_range.start = index + 1;
              }
              '#' => {
                  path_range.end = index;
                  label_range = Some(index + 1..asset_path.len());
                  break;
              }
              _ => {}
          }
      }