johanhaleby / stub-http Goto Github PK

(with-routes! 
  {{:path "/y" :content-type "application/json" :body (json/generate-string {:q "something"})}
   {:status 200 :content-type "application/json"
    :body (json/generate-string {:hello "brave new world"})}}
  (clj-http.client/get (str uri "/y") {:body (json/generate-string {:q "something else"})}))

This works when I wouldn't expect it to. That also make is impossible to have several routes that have the same path but different request bodies without error. I realize that it's not standard to do GET with a body, but some APIs (e.g. Elasticsearch) work that way. Besides, it doesn't make a difference if I use POST.

We'd like to test some timeout and resilience scenarios. Is it possible to add a delay in the request response?

Usually testing this kind of scenario is only possible using mocks/stubs.

https://github.com/technomancy/leiningen/blob/master/doc/DEPLOY.md#releasing-simplified

Requirement on such functions is currently:

(fn [request] <true or false>)

Can this be relaxed to require a truthy return only?

Setting up a route for a PUT request with a body will always fail to match the body.

This is because the PUT body data is keyed on the request with "content" and not "postData".

Line 34 of stub-http.internal.spec needs to use the method to determine the correct key.

Hi,

Thanks for the great library!

Having updated to version 0.2.13 from 0.2.12 I'm now seeing an NPE when stubbing a server that only returns status 500, with no body specified. For example:

(stub/start! {{:method :post :path "/api/foo"} {:status 500}})

yields:

java.lang.NullPointerException
at stub_http.internal.server$create_response.invokeStatic(server.clj:42)
at stub_http.internal.server$create_response.invoke(server.clj:24)
at stub_http.internal.server$new_server_BANG_$fn__38653.invoke(server.clj:106)
at stub_http.internal.server.proxy$fi.iki.elonen.NanoHTTPD$ff19274a.serve(Unknown Source)
at fi.iki.elonen.NanoHTTPD$HTTPSession.execute(NanoHTTPD.java:945)
at fi.iki.elonen.NanoHTTPD$ClientHandler.run(NanoHTTPD.java:192)
at java.lang.Thread.run(Thread.java:750)

If I provide an empty body, there is no exception. Is specifying a body now mandatory?

Thanks!

When stubbing a PATCH method request the stub-request returned from the nano server has no body.
This means tests that rely on the body for generating a response for PATCH request cannot be written.

e.g.

(with-open [server (start! {{:path "/mypath" :method :patch} 
                                             (fn [request] 
                                               {:status 200
                                                ;; the request has a nil body
                                                :body (:body request)})})]
...
)

How can I match /something/:every_uuid ?

(with-routes! 
  {"/something" {:status       200
                 :content-type "application/json"
                 :headers      {"Some Header" "some value"}}}
  (clj-http.client/get (str uri "/something")))

Unlike when content-type is set, the headers that are set aren't available in the response.

{:request-time 201,
 :repeatable? false,
 :protocol-version {:name HTTP, :major 1, :minor 1},
 :streaming? true,
 :chunked? true,
 :reason-phrase OK,
 :headers {Content-Type text/html, Connection close, Transfer-Encoding chunked},
 :orig-content-encoding nil,
 :status 200,
 :length -1,
 :body ,
 :trace-redirects []}

Maybe https://github.com/CodeStory/fluent-http

If so it would be possible to use bindings which can be nice. The server should not be stopped afterwards but the route-state should be reset.

(with-routes! *server*
  [times (atom 0)]
  {"/something" (fn [_] (if (< @times 2)
                            <resp 1>
                            <resp 2>))})