Comments (3)
johanbrook
commented on August 11, 2024
AFAIK, a Meteor publication isn't marked as "ready" if this.stop() is called within it. I might be wrong though.
from meteor-publication-collector.
Gitii
commented on August 11, 2024
I think that, too. My question is: Should the callback passed in to collect(...) be called on stop or not? In 1.0.4 that is the case, in 1.0.7 not.
from meteor-publication-collector.
johanbrook
commented on August 11, 2024
I think it should, that's my opinion. One can check the callback's parameter to see if zero documents were published, hence stop() was called.
Feel free to look into it if you'd like.
from meteor-publication-collector.
Related Issues (20)
- Support publish-composite HOT 11
- Error on stop with meteor-publish-performant-counts HOT 2
- ES6 Error HOT 2
- "ready" event sent twice for publications using the low-level added/changed/removed interface HOT 5
- Error when trying to use stubbed collections for publication tests HOT 3
- Needs license HOT 2
- Breaking with peerlibrary:reactive-publish's "autorun" HOT 2
- Not working with `peerlibrary:reactive-publish` HOT 1
- Support multiple `collector.collect`-calls within 1 test HOT 4
- eslint setup HOT 2
- Exception when publication returns an empty array. HOT 4
- Use universal_publish_handlers when no publication-name is given HOT 2
- Can't use on publication of users HOT 1
- Error: Cannot read property 'call' of undefined HOT 1
- collector.collect() doesn't throw in 1.1.0 HOT 2
- Package doesn't handle limit/skip correctly HOT 2
- Failing to resolve promise or call callback when an publication is empty
- Transfer this package to Meteor Community Packages? HOT 8
- Does not collect results on `ready()` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-publication-collector.