Support publish-composite about meteor-publication-collector HOT 11 CLOSED

@johanbrook
I got test failure without report when I test publish-composite function.

But why in meteor/todos, the publish-composite function can test well?

I checked the package version, meteor/todos got [email protected], and in my project it was johanbrook:[email protected]. But why the older package can test well?

from meteor-publication-collector.

Hm, not sure why they use an older version (https://github.com/meteor/todos/blob/master/.meteor/packages#L73).

Perhaps some recent version of this package broke publish-composite.

from meteor-publication-collector.

@ShinyLeee I'm using the latest versions of both packages, and it works fine here!

If you provide us with a reproduction, I'm happy to see if I can help.

from meteor-publication-collector.

@workflow
Thanks for your kindness,here is reproduction.

from meteor-publication-collector.

@ShinyLeee Hmm your repro isn't failing at my end it seems!

This is on Ubuntu 14.04.

I noted some contradictory error logs here:

I20170127-12:34:43.279(1)? MochaRunner.runServerTests: Starting server side tests with run id ZF6w9b9pbeT6jzEhw
W20170127-12:34:43.743(1)? (STDERR) MochaRunner.runServerTests: failures: 1
I20170127-12:35:34.723(1)? MochaRunner.runServerTests: Starting server side tests with run id LmuGAjtqKrtXnG9XN
W20170127-12:35:34.762(1)? (STDERR) MochaRunner.runServerTests: failures: 0
I20170127-12:35:35.695(1)? MochaRunner.runServerTests: Starting server side tests with run id EzWiCWiJ97mSXrNX2
W20170127-12:35:35.758(1)? (STDERR) MochaRunner.runServerTests: failures: 1

but from the browser output, the tests seem to be passing.

I never triedy practicalmeteor:mocha as a test driver before, let me know if I'm missing something here.

from meteor-publication-collector.

Yeah, the problem is terminal got failure, but browser not show it.
Can u tell me which test driver package used in your project?

from meteor-publication-collector.

@ShinyLeee I am currently using dispatch:mocha, since running only server-side tests.

meteor/todos is using dispatch:mocha-phantomjs

from meteor-publication-collector.

@workflow After use dispatch:mocha package, I have found specific error message in console.The error show done() called multiple times.

from meteor-publication-collector.

@ShinyLeee Thank you for reporting and following up!

Apart from #16, everything else seems to work fine with publish-composite, at least on my end. Would you agree that this issue can therefore be closed?

from meteor-publication-collector.

this is working with publishComposite, you can close ticket.

from meteor-publication-collector.

Yeah！Work fine after 1.0.6. You can close it.

from meteor-publication-collector.