joeyeng / chunkhash-replace-webpack-plugin Goto Github PK

Seems like the plugin has not been updated for a while, could you please fix this deprecation warning with a quick small fix ?

(node:28) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
    at /build/node_modules/chunkhash-replace-dm-webpack-plugin/index.js:21:14
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:71:3)

If you use [name].[chunkHash].css in the ExtractTextPlugin the resulting JS and CSS have the same chunkHash in their names. This is no good since a change to CSS does not change the CSS filename on a rebuild. The best is to use [name].[contentHash].css, but then your plug-in won't update the CSS in my index.html.

I'm running into a problem where c-r-w-p is emitting an index.html that has been transformed into a file containing the single word: undefined. I expect I'll end up using a debugger to walk through and see what's breaking, but just in case: has anyone seen this before?

Everything's very vanilla, and it used to work; I expect this is a version compatibility issue of some kind. I've regrettably not done a production build in a long time, and much of the environment has been upgraded (including Node, to 8.1.4).

Assuming no help here, I'll comment (and close, if appropriate) when I've figured it out.

A quick fix would probably be to change

.replace(/[^a-z0-9]/gi, ''); // TODO: Make this more rigid
to

.replace(/[^a-z0-9_]/gi, ''); // TODO: Make this more rigid

but you may want to address the issues here more comprehensively.