joey3000 / piwik-usersmanagerencrypted Goto Github PK

The current password string comparison in https://github.com/Joey3000/piwik-UsersManagerEncrypted/blob/master/Controller.php#L46 is not constant-time. (See http://codahale.com/a-lesson-in-timing-attacks/ for implications.) See also Piwik issue 9456.

Constant-time examples:

• https://github.com/phpseclib/phpseclib/blob/2.0.0/phpseclib/Crypt/RSA.php#L2201-L2213
• https://github.com/defuse/php-encryption/blob/399fc4c4798b301681888c2608b0ddd060d477da/src/Crypto.php#L409
• https://github.com/phpecc/phpecc/pull/114/files (explanation for usage of mb_strlen() instead of strlen(): phpecc/phpecc#115)

The missing but crucial feature is "salting" passwords before encryption. The salt does not need to be secret, it only needs to have a defined limited validity time, and to be known to both, the client and the server. For UsersManagementEncrypted, the PHP session ID would fit, but can't be accessed from client-side JavaScript (and it shouldn't). I would need to find a work-around for UsersManagementEncrypted. Like sending a nonce or a strong hash of the session ID to the page, or something.)

P.S.: The reason for the need to salt is that, as of now, encrypted passwords can be used in replay attacks. Similarly to a pass-the-hash attack, but passing the encrypted password.

For the LoginEncrypted plugin, see Joey3000/piwik-LoginEncrypted#1.

This is to track Piwik platform updates needed for this plugin to work.

• Piwik update: matomo-org/matomo#8781

As good coding practice, add use strict to all JavaScript functions added or modified by me for this plugin. (The ones not modified by me should stay equal to the original Piwik code.) I.e., in:

• usersSettings.js:

  • piwik-UsersManagerEncrypted/javascripts/usersSettings.js

    Line 12 in fe26286

    function sendUserSettingsAJAX() {

  • piwik-UsersManagerEncrypted/javascripts/usersSettings.js

    Line 62 in fe26286

    function sendAnonymousUserSettingsAJAX() {

  • piwik-UsersManagerEncrypted/javascripts/usersSettings.js

    Line 85 in fe26286

    $(document).ready(function () {

• usersManager.js: Similarly.

Infos:

• http://www.w3schools.com/js/js_strict.asp
• https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Strict_mode

But caution! It must be done in functions only, not on the file level. Because in Piwik, all plugin JS is concatenated, which would make use strict apply to all concatenated files. From the above Mozilla link:

Consider concatenating a strict mode script with a non-strict mode script: the entire concatenation looks strict! [...] It is thus recommended that you enable strict mode on a function-by-function basis (at least during the transition period).