joergbrech / cpp_include_walker Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 822 KB

my first rust project

Rust 99.06% C++ 0.94%

cpp_include_walker's People

Contributors

Watchers

cpp_include_walker's Issues

assumption on include directories

Currently, the two dependencies

#include<vector>
#include "myImpl/vector.hxx"

get the same key, because it is implicitly assumed that all subdirectories of the root directory are passed to the compiler as include directories.

It makes more sense to assume that these point to different files.

rethink SimpleGraph

SimpleGraph is really lean, because it makes no assumptions on memory management and the generic data type. This makes some things hard or inefficient, such as determining the index of a child node, since there is also no assumption on ordering:

cpp_include_walker/src/simple_graph.rs

Line 65 in 85af696

let idx = nodes.iter().position(|&x| x==child).unwrap();

implement topo sort

so far, the nodes are only sorted by used_by.len(), which is the first step.

unit test for simple_graph

There are no unit tests for SimpleGraph, because implementing is not easy. One way to levitate this is to allow values and references into the nodes and children functions of the trait maybe...