joeblackwaslike / coinaddr Goto Github PK

Hi , I've tried installing coinaddr on windows 10 and i haven't been able the install it , it just throws an error and it seems i can't fix it . Please help with the problem .

I've tried installing with pip install coinaddr and python pip install coinaddr

I'll attach a photo of the error .

Hi, thanks for useful library.

One issue, when checking address with wrong currency, we have exception due to strong typing. Here:

    @property
    def network(self):
        """Return network derived from network version bytes."""
        abytes = base58check.b58decode(
            self.request.address, **self.request.extras)

        nbyte = abytes[0]
        for name, networks in self.request.currency.networks.items():
            if nbyte in networks:
                return name

In case of wrong networks you return None, but expecting string. So we have valid=False and exception.

P.S. more currency structures you can find here: https://github.com/ognus/wallet-address-validator/blob/master/src/currencies.js

Coinaddr can't validate this address: 0x0783b48c3e64c12b8ed55ccd409e46e9c0399e74

EOS is the same as ETH and USDT is the same as BTC, so it should be an easy fix to support those two assets.

Coinaddr incorrectly reports bech32 addresses (starting with bc1) as invalid.