jobo3208 / nvim-mysql Goto Github PK

To reproduce, simply do :tabe as soon as nvim starts. Error says:

E117: Unknown function: MySQLTabLine

Like sample, but with no limit

Have :MySQLConnect accept a connection string instead of just a host name. This allows the user to specify ports, usernames, passwords, custom my.cnf files, etc.

(seen in python 2)

when a non-ascii values is part of a warning:

Traceback (most recent call last):
  File "/home/jboyd/.dotfiles/base/vim/pack/nvim-mysql/start/nvim-mysql/rplugin/python/nvim_mysql/__init__.py", line 824, in show_results
    current_tab.results_buffer[:] = format_results(current_tab.results, format_, metadata)
  File "/home/jboyd/.dotfiles/base/vim/pack/nvim-mysql/start/nvim-mysql/rplugin/python/nvim_mysql/__init__.py", line 267, in format_results
    lines.append("({}) {}".format(warning[1], warning[2]))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position 41: ordinal not in range(128)

when a non-ascii value is in a query itself:

e.g. select 'étage'

Traceback (most recent call last):
  File "/home/jboyd/.dotfiles/base/vim/pack/nvim-mysql/start/nvim-mysql/rplugin/python/nvim_mysql/__init__.py", line 646, in exec_query_under_cursor
    current_tab.execute_query(query)
  File "/home/jboyd/.dotfiles/base/vim/pack/nvim-mysql/start/nvim-mysql/rplugin/python/nvim_mysql/__init__.py", line 493, in execute_query
    self.execute_queries([query], False)
  File "/home/jboyd/.dotfiles/base/vim/pack/nvim-mysql/start/nvim-mysql/rplugin/python/nvim_mysql/__init__.py", line 445, in execute_queries
    logger.debug("executing query: {}".format(query))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 8: ordinal not in range(128)

both errors break the plugin completely and require an editor restart

select '' causes an error

Perhaps autocomplete should use its own connection?

It turns out that there's an inconvenient side-effect of the spinner: it doesn't play well with the visual activity indicators in tmux/screen. As soon as you switch away from a window where a query is running, the visual indicator lights up because it detected a change in the spinner. Without the spinner, the visual activity indicator usually indicated that a query was actually done, which was quite useful. We should give the user an option to turn it off.

If use_spinner is not specified in the user's vimrc, it is never initialized.

Running select '▸' causes UnicodeDecodeError and borks the entire connection

e.g., we should not see a stack trace when trying to autocomplete on an invalid table alias

Either make them more specific, or somehow enable them only when plugin is actually being used.

• Maybe an animated "/ - \ |" sequence instead of just the letter "e"
• Maybe show which # query is being executed when executing a series of queries (e.g. "1/5")