Giter Club home page Giter Club logo

Comments (5)

yarnabrina avatar yarnabrina commented on May 24, 2024 1

Hi @JoaquinAmatRodrigo, @JavierEscobarOrtiz, thanks for your comments. Yes, I can definitely start with quantile calculation in sktime.

I just created sktime/sktime#5447 with solution 1 above, and will switch to 2 when available. It'll be great if you can take a look and give some feedbacks on other parts and the feasibility of the TODO comments mentioned in the PR.

from skforecast.

JoaquinAmatRodrigo avatar JoaquinAmatRodrigo commented on May 24, 2024

Hi @yarnabrina,
Thanks for using skforecast.

What you suggest makes perfect sense. Since the heavy computation relies on the bootstrapping process, the user may benefit from calculating multiple quantiles with a single function call.

@JavierEscobarOrtiz What are your thoughts? We will need to check if this change affects the other parts of the API to estimate the effort required. But if all goes well, this may be a feature to include in the next release.

from skforecast.

JavierEscobarOrtiz avatar JavierEscobarOrtiz commented on May 24, 2024

Hello @yarnabrina,

Thanks for opening the issue!

Your suggestion sounds very interesting. It is true that sometimes you are not interested in the lower and upper bounds of an interval, but you are looking for some specific quantiles.

Regarding our method predict_interval, we have discussed and decided to leave it as it is, since the purpose of this method, as its name suggests, is just to get an interval (lower and upper bound).

So, two solutions come to my mind at this point:

  1. You can imitate our predict_interval code and modify the line you pointed out. As I see it, you will not need a for loop because all the calculations are done in predict_bootstraping and you just have to call the desired quantiles with the numpy quantile method.

  2. Since I may be missing some behavior in your code and the feature you suggest is very interesting, we will create a method called predict_quantiles with the behavior you mention for the next version. 😄 This will also help us to avoid making a lot of changes in the code of functions like backtesting_forecaster (since they use the predict_interval method internally).

Hope this comment fits your needs.

from skforecast.

yarnabrina avatar yarnabrina commented on May 24, 2024

Closed by #577 based on my understanding.

from skforecast.

JavierEscobarOrtiz avatar JavierEscobarOrtiz commented on May 24, 2024

@yarnabrina correct,

There will be a change where the output columns of predict_quantile will be named as q_0.05, q_0.50 ...

It will come in a future PR.

from skforecast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.