Giter Club home page Giter Club logo

stest's Introduction

Simple test

Simple practical test.

Try to improve as much as possible the code in the finder class (the rest is just entities an object value): https://github.com/uniplaces/stest/blob/master/src/Uniplaces/STest/ListingFinder.php

Don't change the tests, they all must run: https://github.com/uniplaces/stest/blob/master/tests/Uniplaces/STest/Tests/FindListingsTest.php#L171

After refactoring here's what we expect:

  • ListingFinder and ListingFinderFactory should be easily readable and understandable;
  • The size of ListingFinder should be minimum (it's just a class to "query");
  • Adding new "rules" should be easy and shouldn't require to touch ListingFinder code directly;
  • Hard coded values on ListingFinder shouldn't be hard coded and should be easy to configure;
  • Should be easy to add new types of search eg: 'extra-advanced' without touching the ListingFinder code

Setup

How I Solve

Changes made to be more appropriate.

stest's People

Contributors

eduardosoliv avatar joaomlopes avatar mlimaloureiro avatar

Watchers

James Cloos avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.