Giter Club home page Giter Club logo

Comments (11)

jnavila avatar jnavila commented on August 10, 2024 1

It's merged in master. I'll have to think of an elegant way to pass colors.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

It isn't high on my priority list. I'd like to focus on interactivity and add these options in the browser.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

I can already rework the drawing to make it easier to read.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

The line width can be changed. Which colors would you expect?

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

If you have time, can you test the branch enhance_svg?

 $ git fetch origin
 $ git checkout -b enhance_svg origin/enhance_svg

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

Sure! What should I test? I mean, which enhancements should I find?

  • The line width is better.
  • The colors are darker now but it is even harder for me to distinguish. Previous colors were better.

Anything else?
Is it hard to pass this from the command line? I was looking at the code but as I never saw this language it is pretty much hard to understand where to add this. Of course, I need to study it more. :)

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

Also, plotgitch has a "--help" that calls something like a man page. This is not good. And -h does not work. But plotkicadsh has a good --help|-h flag to show the available command line parameters.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

It is hard to pass the colors to the svgPainter. The code needs to be refactored to have supplementary parameters. For the moment, the thicker line width is kept but the colors are rolled back.

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

Yeap! It is ok.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

see #16

from plotkicadsch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.