Giter Club home page Giter Club logo

Comments (6)

leoheck avatar leoheck commented on August 10, 2024

Ah, a flag to keep the originals would be super good to have! I am using my own git-imgdiff just to save these files.

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

This flag one could keep the originals too.

-k, --keep
by default, the svg diff files are deleted after launching the
viewer; this option lets the files in place after viewing them.

Oh, I already have an issue with this, #52

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

This change involves more rework than what I expected.

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

My bad!

I am following your changes. It looks like you have to change a lot of files for every small feature. Is this something related to the OCaml itself or the features you are changing are not small as I was thinking.

from plotkicadsch.

jnavila avatar jnavila commented on August 10, 2024

The span of changes is mostly due to the chain spanning from commandline argument to low level kicadlib stuff. It seems a lot of volume but it's not a big deal.

This one is more complicated, because the color scheme option is tied to the diffing process when it's internal. What the feature requests is a change in how the schematics are drawn, which is different. In fact, these should be two separated options.

from plotkicadsch.

leoheck avatar leoheck commented on August 10, 2024

Since this is pretty hard to implement I am going to close this issue now. This can be addressed externally in the git-imagediff script, for instance by just replacing the color in the generated images, directly.

from plotkicadsch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.