jmperez / c Goto Github PK

Hi @JMPerez! I really enjoy the idea of this project so thank you for your work!

Currently, I am having trouble getting the audio to work at all. I can queue a song and have it "play" which shows the progress bar moving from start to finish. Am I missing something?

Edit: I have tried running it both locally and on the demo herokuapp.

Seems that the current version has a problem with loading the locale on page transitions ( e.g. using the about link)

steps to reproduce:

1. clone
2. npm install
3. npm run build && npm run start
4. click on the about link

result:

the unexpected error page.

styled-jsx
and
prop-types

are missing. I'll do a PR if I get time.

Do you think something like this would be against the rules of an iOS or Android SDK? I was looking at the requirements and it seems like it would be..

When hitting the login button, it opens the Spotify login page correctly but once it is submitted, error "invalid client". any suggestions or fixes

Is this a good idea? Want to know what you think about it.

Hi, if I clone the project npm install, and npm run dev. It works.

But when I npm run build && npm run start. It fails.

Can you help?

Cool app btw. but if I add a song to the queue I cant hear anything. My bluetooth connected headphones are connected well because I can listen to other web apps.

Hi,

For start, thank you for your work.
It's a good app but isn't usable for party.

• Because often, only the host have a spotify account, and for the spotify api only need the spotify host to cast the sound.. A lot of app of spotify jukebox just ask for the host spotify account and the guest just send a temporary pseudo.

• Why not more responsive on mobile device ? I think the most usage on party is on the smartphone's guest.

• And maybe a vote system and host permissions for reject a sound ?

If you help for the first idea maybe i can help for dev' my other ideas ! I'm to a nodejs dev'.

• الرئيسية
• الخدمات
• المنتجات
• اتصل بنا

Right now, we check whether we should refresh token or not when "loading", but this can cause a problem.

For example, if "loading" happen at 15 minutes before access token is expired, we don't refresh token (we refresh token 10 minutes before expiration). If I stay at the website for more than 15 minutes, the access token will be expired. Of course, the user can refresh token by reloading page, but I think it's better if the application can refresh token automatically when it find out that the access token is expired.

I like your initiative for this collaborative app :). However, from the master branch I can't launch a working application. I'm using node v8.9 and ran npm install from the source dir. After npm run dev webpack compiles succesfully but an error occurs at the web page:

StyleSheet: `insertRule` accepts only strings.
Error: StyleSheet: `insertRule` accepts only strings.
    at invariant (/Users/arryon/projects/c-spotify/node_modules/styled-jsx/dist/lib/stylesheet.js:274:11)
    at StyleSheet.insertRule (/Users/arryon/projects/c-spotify/node_modules/styled-jsx/dist/lib/stylesheet.js:125:7)
    at /Users/arryon/projects/c-spotify/node_modules/styled-jsx/dist/stylesheet-registry.js:88:29
    at Array.map (<anonymous>)
    at StyleSheetRegistry.add (/Users/arryon/projects/c-spotify/node_modules/styled-jsx/dist/stylesheet-registry.js:87:27)
    at JSXStyle.componentWillMount (/Users/arryon/projects/c-spotify/node_modules/styled-jsx/dist/style.js:58:26)
    at resolve (/Users/arryon/projects/c-spotify/node_modules/react-dom/cjs/react-dom-server.node.development.js:2119:12)
    at ReactDOMServerRenderer.render (/Users/arryon/projects/c-spotify/node_modules/react-dom/cjs/react-dom-server.node.development.js:2260:22)
    at ReactDOMServerRenderer.read (/Users/arryon/projects/c-spotify/node_modules/react-dom/cjs/react-dom-server.node.development.js:2234:19)
    at renderToString (/Users/arryon/projects/c-spotify/node_modules/react-dom/cjs/react-dom-server.node.development.js:2501:25)

Searching a bit yielded This issue: vercel/next.js#3442

Seems like what you're doing (defining styles in the render() function) is no longer supported by next.

When going to the heroku link, it says that there is an application error.

Amazing code man; good job!

Ive been testing it and sometimes it just cuts off the song before it finishes and goes with the next track. I havent figured out if it is a specific timeframe when it cuts off, but happens every few songs.

What can I check in the source in order to see this? Or if you have time, give it a check.

Thanks, and again, amazing work

I think that what you want to do is "when there is no expiresIn or now > 10 minutes before expiresIn, you need to refresh token", so the code should be const needsToUpdate = !expiresIn || expiresIn - 10 * 60 * 1000 < Date.now();.

Ignore me if I'm wrong.

I’m getting: Internal Server Error

Would really like to see it in action. Thanks!