Giter Club home page Giter Club logo

jmcglone.github.io's Introduction

jmcglone.github.io

Data for jmcglone.com. Includes customization of Bootstrap 3.0. Blog and pages generated by Jekyll. Hosted on GitHub.

All content on this site is distributed under a Creative Commons Attribution 3.0 Unported License.

NOTE: If you fork or re-use this project, please be sure you:

  • Edit _includes/analytics.html and either
    • Replace the Google Analytics tracking code with your own, or
    • If you don't use Google Analytics, comment the block of code out entirely.
  • Edit _includes/disqus.html and either
    • Replace the disqus_shortname with your own DISQUS username, or
    • If you don't want commenting, remove or comment out the block of code entirely.

Otherwise I will receive GA data and DISQUS comments from your website.

jmcglone.github.io's People

Contributors

bpg1968 avatar dependabot[bot] avatar jmcglone avatar nerdless avatar nik-pavlov avatar yusufmalikul avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

jmcglone.github.io's Issues

Problems with github pages guide css file

Hi there!
Firstly, thanks for taking the time to put your github pages + jekyll guide together. I set up a simple blog following it a couple of years ago.
I'm just getting around to adding more content to it and I found the formatting of bullet lists to be a bit strange: the font was much smaller than the rest of the text.

I think there are some issues with the css file from the tutorial:

p {
    font-size: 1.5em;
    line-height: 1.4em;
    color: #333;
}

Applying a 1.5 multiplier to the font size of paragraph tags results in the headings being quite small in comparison (except h1 which is set to 3em).

ul.posts { 
    margin: 20px auto 40px;
    font-size: 1.5em;
}

ul.posts li {
    list-style: none;
}

This section doesn't work as intended. ul.posts applies to ul tags with class="post". The generated ul tags don't have a class specified so this doesn't work.

My quick solution to both these problems was:

  • Replace the p section with .post. This applies it to all the text in the post since it is surrounded with <div class="post"></div>:
.post {
     font-size: 1.5em;
     line-height: 1.4em;
     color: #333;
 }
  • Replace the ul section with:
.post ul{ 
    margin: 20px auto 40px; 
}

Now this applies to all unordered lists inside div with class="post"
The font size doesn't need to be set anymore since it is set for the whole post.

I'm new to css so this might not be ideal but it looks a lot better than the existing css file to me. I could submit a pull request if you'd like. However, I've migrated to using a jekyll theme since it's incredibly easy to set up using bundler.


Between this and the other open issues, it seems like this tutorial is now fairly out-of-date. Given that it is still on the first page of Google when searching for "jekyll github pages guide", it would be helpful if you added a note at the start of the guide to let people know that it's outdated until you have time to update it. You could point users to the more up-to-date guide hosted on the Github docs page.
Given that a github-hosted resource now exists, it may be better to spend future efforts contributing to that one.

This guide is also referenced by the official Jekyll Github Pages guide which could lead to some frustration for new users. I am going to suggest that they change this link to the github guide as well.

Thanks again for creating this guide when you did! It was very valuable for me to get my blog started and undoubtedly for many others as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.