jmceue360 / python-text-based-game Goto Github PK

The problem with your current menu method it is will only work with one screen and resolution size. I am guessing it will only work on your own screen as on my smaller laptop the visibility looks almost unreadable.

I would switch from using your static menu generator to using console-menu
ex. https://pypi.org/project/console-menu/

this will generate the menu function for you.

You should change your starting line

Current:
#!/usr/bin/python

Change to:
#!/usr/bin/env python

This is the best practice as you do not know where python will be installed in a given environment.

Because this is a console game and not via a browser remove the ascii generated pictures as they only work in one resolution.

You can consider using pyfiglet instead to convert text into an ASCII rendering. see: https://stackoverflow.com/questions/9632995/how-to-easily-print-ascii-art-text for an example.

example:

change:

###-TITLE_SCREEN_MENUS-##########################################################################################################
def main_menu():
    os.system('cls')

To:

def main_menu():
    """ TITLE_SCREEN_MENUS """
    os.system('cls')

These are messy and difficult to read.

example:
#------------------------------Section#1-----------------------------------------------------------------------#