jmarceli / array2xml Goto Github PK

It seems that if you add multiple childs with the same name into an element only the last one will be set.

So if you have a list of products and your parent is 'products' then add 4 children with the name 'product' only the last one will be written into the XML.

Thanks a lot, awesome! :) The example on your github on how to use it is even more awesome! Why isn't everyone making their software manuals that easy!

How could I hardcode this to my xml?

We should add license.

For the sake of consistency, wouldn't be better to always use CDATA blocks for the tag content?

In this way, the value supplied can always be used as is, and will never require any escaping (even if performed automatically).

Also, this would get rid of the # prefix.

Finally, when a tag has both attributes and a value, it should be possible to get rid of both ! and % prefixes by using the first value with numeric key as the value for the tag, that is, instead of

'photos' => array(
  'photo' => array(
	  0 => array(
		  '@mainphoto' => '1',
		  '%' => '1.png',
	  ),
	  1 => array(
		  '@mainphoto' => '0',
		  '%' => '2.png',
	  ),
	  2 => array(
		  '@mainphoto' => '0',
		  '%' => '3.png',
	  )
  )
)

it should be sufficient to write

'photos' => array(
  'photo' => array(
	  0 => array(
		  '@mainphoto' => '1',
		  '1.png',
	  ),
	  1 => array(
		  '@mainphoto' => '0',
		  '2.png',
	  ),
	  2 => array(
		  '@mainphoto' => '0',
		  '3.png',
	  )
  )
)