jleivaizq / djorm-ext-pgtrgm Goto Github PK

I tried the pip version of this plugin as found here https://pypi.python.org/pypi/djorm-ext-pgtrgm/0.3 & got the following error.

File "venv/lib/python3.5/site-packages/djorm_pgtrgm/init.py", line 1, in
from django.db import backend
ImportError: cannot import name 'backend'

The same was mitigated when I downloaded the source from GitHub. Please update the pip package
I am using Django 1.9.4

Let's say you do something like:

Person.objects.filter_o(name__similar='Bobby').select_related('Employer')

if the Employer model also has a name field, you'll get an exception:

Exception Value: column reference "name" is ambiguous
LINE 1: SELECT (similarity(name, 'Bobby')) AS "name_distance...

The SimilarQuerySet class does not include the table name when specifying the field to filter on. To solve this problem you need something like this:

    def filter_o(self, **kwargs):
        qs = super(SimilarQuerySet, self).filter(**kwargs)
        for lookup, query in kwargs.items():
            if lookup.endswith('__similar'):
                field =  lookup.replace('__similar', '')
                select = {'%s_distance' % field: "similarity(%s.%s, '%s')" % (self.model._meta.db_table, field, query)}
                qs = qs.extra(select=select).order_by('-%s_distance' % field)
        return qs

(notice the addition of self.model._meta.db_table).

This line makes djorm-ext-pgtgrm depend on postgis.

That, of course, is not necessary.

When a django ORM .filter() precedes a pgtrgm .filter_o() it raises an AttributeError because the parent model manager returns a QuerySet object rather than a SimilarQuerySet object. SimilarManager should override filter in order to allow it to work with filters that precede or follow a filter_o(). I'll submit a PR.

Django 1.6, postgres 9.1.13 with CREATE EXTENSION pg_trgm;

>>> FooVault.objects.filter(subject__icontains="still")
[<FooVault: 3805>]
>>> FooVault.objects.filter(subject__similar="still")
[]
>>>