jklaiber / jumper Goto Github PK

I saw in https://github.com/jklaiber/jumper/blob/94e9f195fb5802bf36503b44f52f8b0fbb548edb/pkg/inventory/inventory.go#L65C40-L65C40 that only one acccess method is allowed. Since it's possible to configure and use more than one, I think it makes sense to allow also several access methods. @jklaiber What do you think?

I just wanted to install jumper but get the following error:

Is this a known fault?

It would be handy to add the connection port, which should be used.

~ will not work in the config file (.jumper.yaml)

The code panics as soon as I want to connect to a host.

jumper connect -g test test-server
Connecting to 172.16.xx.xx with xxx

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5d8e3c]

goroutine 10 [running]:
golang.org/x/crypto/ssh.(*connection).clientAuthenticate(0xc00020a800, 0xc000216340)
	/go/pkg/mod/golang.org/x/[email protected]/ssh/client_auth.go:65 +0x53c
golang.org/x/crypto/ssh.(*connection).clientHandshake(0xc00020a800, {0xc000016a60, 0xf}, 0xc000216340)
	/go/pkg/mod/golang.org/x/[email protected]/ssh/client.go:113 +0x285
golang.org/x/crypto/ssh.NewClientConn({0x8d6660, 0xc000010030}, {0xc000016a60, 0xf}, 0xc0000b2750)
	/go/pkg/mod/golang.org/x/[email protected]/ssh/client.go:83 +0x12e
golang.org/x/crypto/ssh.Dial({0x825af3?, 0xc000092cc0?}, {0xc000016a60, 0xf}, 0xc0000b2750)
	/go/pkg/mod/golang.org/x/[email protected]/ssh/client.go:177 +0x59
github.com/jklaiber/jumper/pkg/connection.runShell({0x8d5550?, 0xc0000762c0}, {0xc000092cc0?, 0xc000112200?}, 0x8d5550?)
	/github/workspace/pkg/connection/connection.go:87 +0x92
github.com/jklaiber/jumper/pkg/connection.NewConnection.func1()
	/github/workspace/pkg/connection/connection.go:71 +0x36
created by github.com/jklaiber/jumper/pkg/connection.NewConnection
	/github/workspace/pkg/connection/connection.go:70 +0x54d

There can be many reasons for this problem. I will dig into what causes it.

I've noticed that if the inventory contains a wrong-formatted YAML, the whole application is unusable.
I found out that it happens when a tab is used (which is not transformed into whitespace).
After saving the whole application seems broken e.g.

$ jumper edit inventory
2023/08/11 11:17:25 could not create inventory

$ jumper connect test
2023/08/11 11:18:56 could not create inventory

In this case, the inventory file has to be encrypted via ansible-vault, and the content formatted correctly.

To prevent this from happening, it would be wise to implement a validation process after the inventory has been edited. This will ensure that the inventory remains error-free and the application runs smoothly.

The systems secure keyring implementation should be used to initially set a jumper password and then retrieve it.

Have a look at https://github.com/zalando/go-keyring

Hi there,

I suggest we add SSH Agent Forwarding, the same as ssh -A, to simplify management on remote servers.
We must consider whether we want to add the option to the inventory or depend on the SSH config.
Furthermore, it makes sense to have a prompt asking the user if the ssh-agent should be forwarded. If there is a prompt, it may be good if it can be turned off since there may be servers where the Agent should be forwarded without explicit confirmation.

Reference from the ssh man page:

The inventory should support the default Ansible inventory variables in order to have a seamless experience when using an Ansible inventory with jumper.

There should be the possibility to up or download files to or from the remote host.

jumper upload -g testgroup testhost localfolder/test.yaml remotefolder/test.yaml
jumper download -g testgroup testhost remotefolder/test.yaml localfolder/test.yaml