🆒
jjb / better_timeout Goto Github PK
View Code? Open in Web Editor NEWFixing Ruby's standard library Timeout
License: MIT License
better_timeout's Introduction
better_timeout's People
Contributors
Stargazers
Watchers
Forkers
sportnginbetter_timeout's Issues
document and maybe accomadate behavior differences from thread raise settings
Is it really sane and safe?
http://blog.headius.com/2008/02/rubys-threadraise-threadkill-timeoutrb.html
Although you don't have to take my word for it, eventually you're going to have to accept the truth. Thread#kill, Thread#raise, timeout.rb, net/protocol.rb all suffer from these problems. net/protocol.rb could be fixed to use nonblocking IO (select), as could I suspect most of the other libraries, but there is no safe way to use Thread#kill or Thread#raise. Let me repeat that: there is no safe way to use Thread#kill or Thread#raise.
Has anything changed since 2008? Is it really safe to use this gem?
idea: ability to specify ensure seconds
--- a/lib/better_timeout.rb
+++ b/lib/better_timeout.rb
@@ -64,7 +64,7 @@ module Timeout
x.raise e
else
x.raise exception, "execution expired"
- x.join
+ x.join(3.1)#(ensure_seconds) <-- this can be a feature of better timeout - option to give inner code ensure_seconds for ensure to finish
current_thread.raise exception, "execution expired"
end
}Thanks for this library!
Thanks for this. It's one of the only implementations of a timeout in ruby that will actually timeout when it is supposed to. One problem we had with it is that we don't want to use it for everything just specific http requests. Would you be open to accepting a PR that wraps the entire library in a SaneTimeout module? Namespacing it and allow it to be used at will vs requiring it to be used on every timeout has worked very well for us. Here are the changes we've made so far master...sportngin:master
ponder this behavior explanation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.