jiripospisil / parsley-rails Goto Github PK

Parsley.js bundled for Rails Asset Pipeline

License: MIT License

Ruby 39.77% Shell 60.23%

parsley-rails's Introduction

Parsley.js for Rails Asset Pipeline

Parsley.js is an awesome form validation library (documentation). This gem makes it easy to use it with Rails Asset Pipeline.

Installation

Add this line to your application's Gemfile:

gem "parsley-rails"

And then execute:

$ bundle

Usage

Add the following to your app/assets/javascripts/application.js:

//= require jquery
//= require parsley

To use a different i18n, add this right after:

//= require parsley.i18n.fr

Finally, if you want to use the default CSS, add the following to your app/assets/stylesheets/application.css:

*= require parsley

Sass Support

If you prefer SCSS, add this to your application.css.scss file:

@import 'parsley';

If you use the Sass indented syntax, add this to your application.css.sass file:

@import parsley

See the complete Parsley.js documentation.

Versions

The gem follows Parsley.js' versions. If the gem's version is 2.0.0.0, then 2.0.0 is a version of Parsley.js and 0 is a patch level of the gem itself.

Contributing

Fork it
Create your feature branch (git checkout -b my-new-feature)
Commit your changes (git commit -am 'Add some feature')
Push to the branch (git push origin my-new-feature)
Create new Pull Request Note that there's a script (./update.sh 2.6.5) for automatic update from the official distribution. Unfortunately the files in the "extras" are not part of the distribution and thus are not transpiled. And since I'm too lazy to reliably script it, it's necessary to modify some of the files (comparison.js as of now) and remove the offending lines.

parsley-rails's People

Contributors

Stargazers

Watchers

parsley-rails's Issues

End of file reached error

Hi,
I have added the gem to my app and getting the following error on staging environment:

ActionView::Template::Error (end of file reached):
    14:     = favicon_link_tag 'favicon.ico?v=1'
    15:     = stylesheet_link_tag 'fonts/gotham', media: "all"
    16:     = stylesheet_link_tag "pages_v1", :media => "all"
    17:     = javascript_include_tag "admin"
    18:     = csrf_meta_tags
    19:   %body.admin{style: ""}
    20:     #sticky-anchor

Did you come across this and do you know why this is happening?

Update to latest version of Parsley

Hey there,

are you planning any updates in close future?

Best practices for Turbolinks?

Do you have suggestions for how to best incorporate Parsley.js with Turbolinks enabled pages?
I started out with:

function initParsley() {
  $("form.has_validations").length && $("form.has_validations").parsley()
};

var run_ready;
function run_ready() {
  initParsley();
};

$(document).ready(run_ready);
$(document).on('turbolinks:load', run_ready);

But found that on turbolinks restore events, I would see duplicate parsley error annotations:

The only way found around this seemed a bit hacky:

function initParsley() {
  $("form.has_validations").find("ul.parsley-errors-list li").remove();  
  $("form.has_validations").length && $("form.has_validations").parsley().reset();
  $("form.has_validations").length && $("form.has_validations").parsley().validate();
};

var run_ready;
function run_ready() {
  initParsley();
};

$(document).ready(run_ready);
$(document).on('turbolinks:load', run_ready);

Do you have any suggestions for best practices when using parsley-rails with Turbolinks 5 enabled?

//= require parsley.remote

This file is not the part of your gem ?
https://github.com/guillaumepotier/Parsley.js/blob/9b9b44fcb530565d7d489fca0e1343b3c162fdfd/src/parsley/remote.js

Rails fails to find file parsley.remote

When using setup instructions (add gem to gemfile, run bundle, add requires to application.js, etc), Rails fails with message: couldn't find file 'parsley.remote' (sprockets error).

Manually downloading and adding parsley.remote to vendor folder solves the problem, but breaks gem 'up-to-date' capailities =]

Any clues? May I be doing something wrong?!

Documentation links in the README are broken

They point to http://parsleyjs.org/documentation.html

License missing from gemspec

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can image, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

Failed to load resource parsley.js.map

Running on ruby 2.3.1, rails 4.0.1
Install correctly gem, but after reloading server get an error
Failed to load resource: the server responded with a status of 404 (Not Found) http://localhost:3000/assets/parsley.js.map

css

Can u add default css ?

Data-remote conflict with Rails

This issue was pointed out on the main Parsley.js forum.

guillaumepotier/Parsley.js#143

I've been having trouble with it too -- data-remote on a Rails form screws things up with Parsley. Guillaume has suggested a window.ParsleyConfig fix to this -- maybe you could work it into your gem?

I'd give it a try and do a pull request, but i'd probably just break things, lol.

There is the error when I trying to add the file that it not in the path:

./log/development.log:ActionView::Template::Error (couldn't find file 'parsley' with type 'application/javascript'):

I've followed all the steps according to the README file.