jirihorky / ioapps Goto Github PK

The images on the screenshot page are no more present.

This causes ioreplay to graph wrong plots where the write file offset starts 
from zero and from the last known filesize.

failing part of strace 
(/home/keruom/fzu/acat2013/lysak.cache.on.new.files/strace.dcap.server.35.head):

16435 1368689283.931320 read(964, ""..., 4) = 4 <0.000047>
16435 1368689283.931444 write(964, ""..., 16) = 16 <0.000046>
16435 1368689283.931566 dup2(210, 964) = 964 <0.000039>
16435 1368689283.931651 close(964) = 0 <0.000038>

What's interesting is that the fd 964 was already opened. Apparently, this is 
ok behavior (man 2 dup2):

       dup2() makes newfd be the copy of oldfd, closing newfd first if necessary, but note the following:

       *  If oldfd is not a valid file descriptor, then the call fails, and newfd is not closed.

Jiri Horky

./ioprofiler /home/keruom/fzu/acat2013/lysak.cache.off.new.files
/home/keruom/fzu/acat2013/lysak.cache.off.new.files
/home/keruom/fzu/acat2013/lysak.cache.off.new.files
Segmentation fault (core dumped)

 ls -ld /home/keruom/fzu/acat2013/lysak.cache.off.new.files
drwxr-xr-x 2 keruom keruom 4096 May 16 06:24 
/home/keruom/fzu/acat2013/lysak.cache.off.new.files

What steps will reproduce the problem?
1. ioprofiler-trace grep nada /dev/null
2. ioprofiler ioproftrace.log

What is the expected output? What do you see instead?
expected: no errors.
instead: GUI comes up, but complains on the command line about

E!![../in_strace.c:strace_read_stat:980]: Error: It was not able to match all 
fields required: 3
E!![../in_strace.c:strace_read_stat:981]: Failing line: 2945  1379691850.276926 
stat("/dev/null", {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 3), ...}) = 0 
<0.000035>

E!![../in_strace.c:strace_get_items:1382]: Error parsing file ioproftrace.log: 
on line 22, position 1733


What version of the product are you using? On what operating system?

1.4-r2, RHEL6-clone, x86_64

What steps will reproduce the problem?
1. "make install"

What is the expected output? What do you see instead?

Will try to write into /usr/bin and other system directories. Not good for when 
packaging the software, or for running as non-root. Suggest to support the 
DESTDIR Makefile variable (this is fairly widely used), see attached patch.

The Makefile in current svn (revision 117 at least)
mentions a print.c, and ioreplay.c includes a print.h.  

These files appear to be missing from the repository, but weren't needed as of 
the last release.

What steps will reproduce the problem?
1. run ioprofiler.py with an argument

What is the expected output? What do you see instead?

Arguments are currently ignored. It would be a substantial enhancement to 
accept strace data from a file given as an argument.  A --help option would 
also be nice.

Please have a look at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=730505

And the proposed patch:

--- ioapps-1.4r2.orig/replicate.c
+++ ioapps-1.4r2/replicate.c
@@ -67,7 +67,27 @@ unsigned long long clock_rate = 0;

 struct timeval start_time;

+#ifdef __powerpc__
+static inline unsigned long long rdtsc(void)
+{
+   unsigned long long int result;
+   unsigned long int upper, lower, tmp;
+   __asm__ volatile(
+           "0:                     \n"
+           "\tmftbu   %0           \n"
+           "\tmftb    %1           \n"
+           "\tmftbu   %2           \n"
+           "\tcmpw    %2,%0        \n"
+           "\tbne     0b           \n"
+           : "=r"(upper), "=r"(lower), "=r"(tmp)
+           );
+   result = upper;
+   result = result << 32;
+   result = result | lower;

+   return result;
+}
+#else
 static inline unsigned long long int rdtsc(void) {
    unsigned a, d;

@@ -75,6 +95,7 @@ static inline unsigned long long int rdt

    return ((unsigned long long)a) | (((unsigned long long)d) << 32);;
 }
+#endif

 unsigned long long  get_clock_rate() {
    unsigned long long x1;

./ioprofiler /home/keruom/fzu/acat2013/lysak.cache.off.new.files
/home/keruom/fzu/acat2013/lysak.cache.off.new.files
/home/keruom/fzu/acat2013/lysak.cache.off.new.files
Segmentation fault (core dumped)

 ls -ld /home/keruom/fzu/acat2013/lysak.cache.off.new.files
drwxr-xr-x 2 keruom keruom 4096 May 16 06:24 
/home/keruom/fzu/acat2013/lysak.cache.off.new.files

What steps will reproduce the problem?
1. Enable the build with GCC Hardening flags as explained here: 
https://wiki.debian.org/Hardening


What is the expected output? What do you see instead?
Build fails as explained in the attached log.

What version of the product are you using? On what operating system?
1.4r2

Please provide any additional information below.
build log attached