Hi,

The trailing comma in class definitions is causing failures on RHEL6 with puppet from EPEL.

Removing these trailing commas will make the module more portable.

Thanks,
Spenser

the module currently uses deprecated functions.

Warning: This method is deprecated, please use the stdlib validate_legacy function, with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/devvm/modules/udev/manifests/init.pp", 27]

could you please resolve them and issue a new release?

I have a udev rule that increases block timeouts for virtual machine block devices:

# cat /etc/udev/rules.d/99-blk-timeout.rules 
ACTION=="add", SUBSYSTEMS=="scsi", ATTRS{vendor}=="VMware*", ATTRS{model}=="Virtual disk*", RUN+="/bin/sh -c 'echo 119 >/sys$DEVPATH/timeout'"

Executing a simple udevadm trigger does not invoke the "add" event needed to apply this rule.

To get this to work from the command like i have to run the following:

udevadm trigger --action="add" --subsystem-match="scsi" --attr-match=vendor="VMware*" --attr-match=model="Virtual disk*"

Or, in the case of puppet i've created an exec {} resources to perform this.

  # Set timeout to 120 seconds for all VMware block devices
  # to test: udevadm info -q all -a /dev/sda | grep timeout
  udev::rule { '99-blk-timeout.rules':
    ensure  => present,
    content => "ACTION==\"add\", SUBSYSTEMS==\"scsi\", ATTRS{vendor}==\"VMware*\", ATTRS{model}==\"Virtual disk*\", RUN+=\"/bin/sh -c 'echo 119 >/sys\$DEVPATH/timeout\'\"\n",
    notify  => Exec['udevadm trigger 99-blk-timeout.rules'],
  }
  # end udev rule
  exec { 'udevadm trigger 99-blk-timeout.rules':
    command     => '/usr/sbin/udevadm trigger --action="add" --subsystem-match="scsi" --attr-match=vendor="VMware*" --attr-match=model="Virtual disk*"',
    refreshonly => true,
    subscribe   => Udev::Rule['99-blk-timeout.rules'],
  }
  # end execute udevadm trigger

This is an OK solution, however udevadm trigger is being called twice. Once by udevadm::trigger and once by my exec call.

It would be awesome if we could pass in additional options into the udevadm trigger command so i didn't need my extra exec resource.

Maybe something like:

  udev::rule { '99-blk-timeout.rules':
    ensure  => present,
    content => "ACTION==\"add\", SUBSYSTEMS==\"scsi\", ATTRS{vendor}==\"VMware*\", ATTRS{model}==\"Virtual disk*\", RUN+=\"/bin/sh -c 'echo 119 >/sys\$DEVPATH/timeout\'\"\n",
    trigger_options => '--action="add" --subsystem-match="scsi" --attr-match=vendor="VMware*" --attr-match=model="Virtual disk*"',
  }

Please tag a new release version now that #13 is merged.
Thanks

This module has been neglected for a few years and needs modernization to continue to be used. I believe that https://github.com/voxpupuli/puppet-systemd contains equivalent functionality. Is there a [good] reason to modernize this module or should it be officially deprecated in favor of puppet/systemd? Please let me know you are still using this module.

/CC
@sazzle2611
@riton
@schlitzered
@nmaludy
@jcpunk
@Tilum
@Spenser309
@vStone
@kobybr
@hfrenzel
@nexecook
@noodle10000
@ajmaidak
@sam-wouters
@pecastro
@oholiab
@nenioscio
@ekohl

Could a hash parameter be added to init.pp optionally create udev rules via create resources?

If possible I'd prefer to specify my needed udev rules in an ENC or Hiera. Making a class to contain:

  udev::rule { '60-raw.rules':
  ensure  => present,
  content => 'ACTION=="add", KERNEL=="sda", RUN+="/bin/raw /dev/raw/raw1 %N"',
  }

is less elegant than setting specifics via the external source.

classes:
  udev:
    rules:
      60-raw.rules:
        content: ACTION=="add", KERNEL=="sda", RUN+="/bin/raw /dev/raw/raw1 %N"

Hi,

We're currently using your latest forge module v2.3.0.
We've seen that your master branch does have support for EL8.

Can you please release this version to the Puppet forge 🙏

Thanks

We currently use this module with puppetlabs-stdlib v5.2.0 and it works great but whenever we want to install new modules we get an error that not all dependencies can be satisfied so we have to then add the --ignore-dependencies flag and then have to install all dependencies manually.

If we downgrade to puppetlabs-stdlib < v5 then we will have the same problem as we have other modules that require version greater than 5.

The current situation is workable but it's a pain so would really appreciate it if this could be done.

Thanks,
Sarah

With the latest version of puppetserver, we encounter the following error:

Evaluation Error: Error while evaluating a Function Call, 
Module udev is not supported on RedHat release 7 at /etc/puppetlabs/code/environments/production/modules/udev/manifests/params.pp:42:13

We've tested that the error fades away if we cast operatingsystemmajrelease to either string or integer.