jhickman / gxt-uibinder Goto Github PK

What steps will reproduce the problem?
1. Define a FormPanel
2. Set labelWidth to anything
3. Set fieldWidth to anything
4. Add a TextArea to the form

What is the expected output? What do you see instead?
- For me, the fieldWidth of the TextArea stays the same regardless of the 
fieldWidth I specify. Also the labelWidth stays the same (100px I think) 
regardless of the defined labelWidth. I also noticed this on the GXT-UiBinder 
demo page. The labels are 100px but they should be 75 by default.

What version of the product are you using? On what operating system?
Win Xp and Win 7. Gxt 2.2.5. Latest gxt-uibinder and customuibinder.

Please provide any additional information below.
- In case you can't reproduce it I can provide any other layout information 
that's needed.

What steps will reproduce the problem?
1. Include project with a GWT 2.2 application

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Latest 0.9

Please provide any additional information below.

The current project is built with GWT 2.1 which is incompatible with GWT 2.2 as 
the following error occurs:

[INFO] java.lang.IncompatibleClassChangeError: Found interface 
com.google.gwt.core.ext.typeinfo.JClassType, but class was expected

This has effected other 3rd party projects as well: see 
http://code.google.com/p/gwt-platform/issues/detail?id=292 for details

The styleAttribute attribute for BorderLayout only supports a single style 
value setting (ie styleAttribute="padding,5px")   this should be changed to use 
the ElementParserUtil (ie  styleAttribute="padding:5px; backgroundColor:black")

This change would not be backwards compatible, so must wait until a major 
version release.

The Widgets from GXT we use in our projects are the following. This is not a 
request for implementation I expect to be done, just for information what we 
are using. Let me know which of them can be used with UiBinder as is.

Also, with some guidance to get started, I might be able to spend some time to 
provide patches to implement some of these Widgets.

So, here it goes:

Window

FormPanel
FieldSet

AbsoluteLayout
FloatLayout
FitLayout
RowLayout

LabelField
TextField
NumberField
DateField
RadioGroup
Radio
Checkbox

MenuBarItem
MenuItem

When using a LayoutContainer and nested "layoutdata" child elements, it causes 
the the add method to be called in an incorrect order if some have layoutdata, 
but others don't.

To recreate:

<gxt:LayoutContainer layout="FlowLayout">
    <button:Button text="button 1" />

    <gxt:layoutdata type="FlowData" margins="5:>
        <button:Button text="button 2" />
    </gxt:layoutdata>
</gxt:LayoutContainer>

Button 2 ends up appearing first.  This is due to consuming the layoutdata 
child elements first.

What steps will reproduce the problem?
1. Create a form panel with:
<form:AdapterField fieldLabel="...">
    <button:Button text="Form Button" />
</form:AdapterField>

What is the expected output? What do you see instead?
The button should be wrapped in an AdapterField and displayed in the form.  
Instead, UiBinder crashes with the error "[ERROR] [client] - Found unexpected 
child element Element <button:Button text='Form Button'> (:40)".

What version of the product are you using? On what operating system?
gxt-uibinder 0.6
Internet Explorer 8
Windows 7

Please provide any additional information below.
Alternatively any non-field element included in a FormLayout could 
automagically be wrapped in an AdapterField with attributes such as fieldLabel 
being passed through to the AdapterField.  This would be nice and produce 
cleaner XML files, but it could also be confusing as it would obfuscate the GXT 
spec that says only Field subclasses are displayed in a FormLayout.

Description of new feature:
Programmatically, you can add ToolButtons to the ContentPanel header using code 
such as:

panel.getHeader().addTool(new ToolButton("x-tool-gear"));

Sample UiBinder XML:
{{{
<gxt:LayoutContainer>
...
</gxt:LayoutContainer>
}}}

Modify the Maven pom dependency to gwt-customuibinder to not use a system path

What steps will reproduce the problem?
1. add this to to *.ui.xml
    <gxt:CardPanel>
        <gxt-form:FieldSet heading="yyy"/>
        <gxt-form:FieldSet heading="zzz"/>
    </gxt:CardPanel>

What is the expected output?
Only one fieldset visible.
What do you see instead?
Both field sets, one below another.

What version of the product are you using? On what operating system?
1.0.1

Please provide any additional information below.
in generated *UiBinderImp*.java the method setLayout(FlowLayout) is called 
explicitly, although there's no attribute "layout".

http://code.google.com/p/gxt-uibinder/source/browse/gxt-uibinder/src/com/jhickma
n/web/gwt/gxtuibinder/elementparsers/LayoutContainerParser.java#56

What steps will reproduce the problem?
1. BorderLayout size expects an "int" and only allows the size to be set in 
pixels

Please provide any additional information below.
The GXT API shows BorderLayoutData::setSize(float size) as allowing a float 
such that values < 1 are interpretted as a percentage.

Issue has been discussed here: 
http://groups.google.com/group/gxt-uibinder/browse_thread/thread/a623950de858c75
c

Since I use HBoxLayout (and to some extent, VBoxLayout) combined with RowLayout 
for 90% of the layouts I do, I would love to see HBoxLayout and VBoxLayout 
supported in the near future, if possible.

thanks!

The SimpleComboBox is currently able to handle this:

<form:SimpleComboBox 
     ui:field="blah" 
     width="80" triggerAction="ALL" 
     editable="false" 
     simpleValue="{constants.before}">
   <form:value>before</form:value>
   <form:value>after</form:value>
</form:SimpleComboBox>

How hard would it be to support this:
<form:SimpleComboBox 
     ui:field="blah" 
     width="80" triggerAction="ALL" 
     editable="false" 
     simpleValue="{constants.before}">
    <form:value add="{constants.before}"/>
    <form:value add="{constants.after}"/>
</form:SimpleComboBox>

?

This would allow me to use I18N constants (and messages).

thanks,
JR

It would be nice to be able to use TableLayout and ColumnLayout in UiBinder.

Description of new feature:
Support the MarginData type for adding objects to a LayoutContainer.

Sample UiBinder XML:
<gxt:LayoutContainer>

    <gxt:layoutdata type="MarginData" margins="10">
        <gxt:ContentPanel />
    </gxt:layoutdata>
...
</gxt:LayoutContainer>

What steps will reproduce the problem?
1. Create a <form:FormPanel> element with no layout attribute.

What is the expected output? What do you see instead?
Form fields are rendered with no fieldLabels; they should be rendered with.

What version of the product are you using? On what operating system?
gxt-uibinder-0.6
Windows 7
Internet Explorer 8

Please provide any additional information below.
There does not seem to be any special handling for FormPanel so its layout is 
parsed the same as any LayoutContainer.  This results in the default layout 
being a FlowLayout as opposed to a FormLayout as the Sencha Javadoc specifies.

What steps will reproduce the problem?
1. Set the project to use GXT 2.2.6 and GWT 2.5.
2. Create a *.ui.xml file that uses any GXT widget (via gxt-uibinder)


What is the expected output? What do you see instead?
The screens will load.

What version of the product are you using? On what operating system?
1.0.0 (latest, tried HEAD from the repo as well)

Please provide any additional information below.
It looks like GWT had some pretty large changes to the UiBinder generation 
code, which completely broke the hooks that gxt-uibinder was using to provide 
GXT2 support in UiBinder.  It would be great to see this library updated to 
continue to support GXT 2.x on GWT 2.5 and beyond.

I am trying to get @GxtUiHandler to work with either 'Select' or 
'SelectionChanged' event on TreePanel.

I have done this successfully with:
tree.getSelectionModel().addSelectionChangedListener(
     new SelectionChangedListener<ModelData>() {
   @Override public void 
        selectionChanged(SelectionChangedEvent<ModelData> se) {
            ModelData md = se.getSelectedItem();
             etc...
        });

But this (and various other combinations/permutations) does not work:
@GxtUiHandler(eventType=GxtEvent.SelectionChange, uiField={"tree"})
    public void handleSelection(TreePanelEvent<BaseTreeModel> tpe){
    BaseTreeModel btm = tpe.getItem();
    String name = btm.get(NAME_FIELD);
    fireSelectedHandlers(name);

    System.err.println("selected " + name);
    }

Also, this works on TreePanel for CheckChange events:
@GxtUiHandler(
              eventType = GxtEvent.CheckChange, 
              uiField = { "tree" })
public void handleCheck(TreePanelEvent<BaseTreeModel> be) {
    ModelData md = be.getItem();
    BaseTreeModel btm = be.getItem();
    String name = md.get(NAME_FIELD);
    boolean checked = be.isChecked();
    String checkedTxt = (checked?"checked":"unchecked"); 
    System.err.println( name +" was " + checkedTxt);
    if(btm.getChildCount()>0){
        System.err.println(" has children ");
    }
}


any thoughts on why this is not working (I am not getting to the breakpoint at 
first line in handler method.

From Google groups discussion:

Slightly off topic, but is there a reason you followed that convention 
for button menus?  I'm looking at making a patch to support custom 
menu types and I see two ways of doing it.  1) Add a type attribute to 
the menu element.  2) Replace the menu element with simply accepting 
<menu:Menu> elements so <menu:ColorMenu> and the like could be used. 
1 sticks with your convention for border layout, which would be good 
if there was a specific reason for it.  2 follows the general usage of 
UiBinder which you also use for MenuBar. 

What steps will reproduce the problem?
1. Compile project

What do you see instead?
[INFO] --- gwt-maven-plugin:2.3.0:compile (default) @ sbrf-deposit-web ---
[INFO] auto discovered modules 
[com.aplana.sbrf.deposit.persistence.custom.Business, 
com.aplana.sbrf.deposit.web.common.Common, 
com.aplana.sbrf.deposit.web.custom.Deposit]
[INFO] Compiling module com.aplana.sbrf.deposit.web.custom.Deposit
[INFO]    Scanning for additional dependencies: 
file:/C:/Documents/work/iasd/wss/ws0/sbrf-deposit-web/src/main/java/com/aplana/s
brf/deposit/web/custom/client/feature/byexamples/uibinder/EasyForm.java
[INFO]       Computing all possible rebind results for 
'com.aplana.sbrf.deposit.web.custom.client.feature.byexamples.uibinder.EasyForm.
EasyFormUiBinder'
[INFO]          Rebinding 
com.aplana.sbrf.deposit.web.custom.client.feature.byexamples.uibinder.EasyForm.E
asyFormUiBinder
[INFO]             Invoking generator 
com.google.gwt.uibinder.rebind.CustomUiBinderGenerator
[INFO]                [WARN] Configuration property 
UiBinder.useSafeHtmlTemplates is false! UiBinder SafeHtml integration is off, 
leaving your users more vulnerable to cross-site scripting attacks. This 
property will default to true in future releases of GWT.
[INFO]                [WARN] Problem using reflection: 
java.lang.reflect.InvocationTargetException
[INFO]       [WARN] For the following type(s), generated source was never 
committed (did you forget to call commit()?)
[INFO]          [WARN] 
com.aplana.sbrf.deposit.web.custom.client.feature.byexamples.uibinder.EasyForm_E
asyFormUiBinderImpl
[INFO]    [ERROR] Errors in 
'file:/C:/Documents/work/iasd/wss/ws0/sbrf-deposit-web/src/main/java/com/aplana/
sbrf/deposit/web/custom/client/feature/byexamples/uibinder/EasyForm.java'
[INFO]       [ERROR] Line 25:  Failed to resolve 
'com.aplana.sbrf.deposit.web.custom.client.feature.byexamples.uibinder.EasyForm.
EasyFormUiBinder' via deferred binding
[INFO]    [ERROR] Errors in 
'file:/C:/Documents/work/iasd/wss/ws0/sbrf-deposit-web/src/main/java/com/aplana/
sbrf/deposit/web/custom/client/feature/depo/uibinder/DepoForm.java'
[INFO]       [ERROR]  Internal compiler error
[INFO] java.lang.IncompatibleClassChangeError: Found interface 
com.google.gwt.core.ext.typeinfo.JClassType, but class was expected
[INFO]  at 
com.jhickman.web.gwt.gxtuibinder.elementparsers.util.ElementParserUtil.fetchSett
erMethods(ElementParserUtil.java:117)
[INFO]  at 
com.jhickman.web.gwt.gxtuibinder.elementparsers.util.ElementParserUtil.applyAttr
ibutes(ElementParserUtil.java:68)
[INFO]  at 
com.jhickman.web.gwt.gxtuibinder.elementparsers.ComponentParser.parse(ComponentP
arser.java:46)
[INFO]  at 
com.google.gwt.uibinder.rebind.UiBinderWriter.parseElementToField(UiBinderWriter
.java:652)


What version of the product are you using? On what operating system?
gwt 2.3.0
gwt-maven-plugin 2.3.0
gxt 2.2.3
gwt-customuibinder 1.1.0
gxt-uibinder 1.0.1


Please provide any additional information below.

java.lang.IncompatibleClassChangeError: Found interface 
com.google.gwt.core.ext.typeinfo.JClassType
The project is not contains GXT widgets and compile success whithout GXT and 
GXT-UiBinder. But I need this. Help))

What steps will reproduce the problem?
1. extend com.extjs.gxt.ui.client.widget.grid.Grid
2. add static methods:
 private static ListStore createStore();
 private static ColumnModel createColumnModel();
3. create default constructor:
 super(createStore(), createColumnModel());

What is the expected output? 
default constructor is called by ui binder

What do you see instead?
error "Attribute 'store' is required"

What version of the product are you using? On what operating system?
gxt-uibinder-1.0.1.jar
gxt-custombinder-1.0.2.jar

Description of new feature:
Although it's not a setter, it might be useful to support a text attribute that 
can call addText() on LayoutContainers

Sample UiBinder XML:
<gxt:LayoutContainer
    text="{data.shortText}" />

http://code.google.com/p/gxt-uibinder/source/browse/gxt-uibinder/src/com/jhickma
n/web/gwt/gxtuibinder/elementparsers/layout/LayoutDataFieldFactory.java#93
missing: .getAttribute("layoutRegion")

You forbid usage of gxt:layoutdata inside BorderLayout; is it leftover code?
What if I don't want to use gxt:north/center etc., because I've overriden 
BorderLayoutData?

Buttons support menus.  Programmatically, the code looks like:

  Menu menu = new Menu();
  menu.add(new MenuItem("test"));
  Button b = new Button();
  b.setMenu(menu);

like this:

<form:SimpleComboBox width="80">
   <form:SimpleComboValue>"before"</form:SimpleComboValue>
   <form:SimpleComboValue>"after"</form:SimpleComboValue>
</form:SimpleComboBox>

??

Need to add support for FlowLayout for subclasses of LayoutContainer

What steps will reproduce the problem?
1. Create a <gxt:LayoutContainer layout="FillLayout">

What is the expected output? What do you see instead?
The LayoutContainer should be constructed with a FillLayout.  Instead, UiBinder 
crashes with the error "[ERROR] [client] - 'layout' must be one of ... but 
found FillLayout Element <gxt:LayoutContainer layout='FillLayout' 
rowLayoutOrientation='HORIZONTAL'> (:49)".

What version of the product are you using? On what operating system?
gxt-uibinder 0.6
Internet Explorer 8
Windows 7

Please provide any additional information below.
I think FillLayout should be able to be handled simply as a RowLayout since it 
extends it.  However, it would probably be good to rename rowLayoutOrientation 
to something that would work for both of them.

It seems like there are only 2 events handled currently.
Select and Change.

this is a nice to have, I guess, since there is the boiler-plate code way of 
doing it also.

Great job Justin!. Toolbar implementation in uiBinder would be a convenient 
feature too.

What steps will reproduce the problem?
1. Create a custom radio group which extends from Gxt radio group. Add the new 
custom component to the ui binder xml file and enclose that with custom radio 
components which extends from gxt radio.

What is the expected output? What do you see instead?
I expected to see radio coming up within the radio group. But I got this error 
instead during compilation. 

RadioGroup can only contain Radio children, but found '<my:MyRadio>'. Element 
<my:MyRadioGroup>

It works fine if I switch to the gxt component. 


What version of the product are you using? On what operating system?
gxt-uibinder-0.11.jar; Windows 7

Please provide any additional information below.
It fails for  the custom group components like radio group, checkbox group. I 
modified  RadioGroupParser, but found more modifications were 
required.

Description of new feature:
Add support for AdapterMenuItem widgets.  AdapterMenuItem has a single 
constructor that takes a Widget. This should be the nested element.

Sample UiBinder XML:
<menu:AdapterMenuItem>
    <form:ComboBox ... />
</menu:AdapterMenuItem>

Do some research and find out what it would take to get gxt-uibinder (and 
gwt-customuibinder) in a public Maven repository.

OS: Windows7, gxt 2.2.4, gxt-uibinder 1.0.1, gwt-customuibinder 1.1.0
A view declaration like this:
----------------------------------------------------------------------
<gxt:LayoutContainer layout="BorderLayout" styleName="background">
 <gxt:center margins="3,3,3,3">
  <gxt:TabPanel>
   <gxt:TabItem text="Tab1">
    <gxt:ContentPanel headerVisible="false" layout="FitLayout">
     <gxt:LayoutContainer>
      <gxt:layout type="VBoxLayout" boxLayoutAlign="STRETCH"/>
       <gxt:layoutdata type="VBoxLayoutData" margins="5" flex="1">
        <button:Button text="Button 1" />
       </gxt:layoutdata>
       <gxt:layoutdata type="VBoxLayoutData" margins="5" flex="2">
        <button:Button text="Button 2" />
       </gxt:layoutdata>
     </gxt:LayoutContainer>
    </gxt:ContentPanel>
   </gxt:TabItem>
  <gxt:TabPanel>
 </gxt:center>
</gxt:LayoutContainer>
---------------------------------------------------------------------
is rendered to a visible tab header and an invisible tab body.
Precisely: the 2 top div-elements of the tab body elements have no height. 
Inside the elements seem to be rendered correctly.
I tried to put some other containers between TabItem and the BoxLayout but 
nothing changed. Looks like any BoxLayout somewhere inside a TabItem causes the 
tab body not to be rendered..

I don't know if this is already available, if not, I would definitely want to 
see TreePanel supported.
thanks.
jr

Description of new feature:
BoxComponent.setPosition(int, int) takes two arguments.  Support this by 
accepting a comma separate pair of integer values.

Sample UiBinder XML:
<gxt:LayoutContainer position="10, 10" >
...
</gxt:LayoutContainer>

Add support for GWT-Designer Eclipse plugin.