jgoz / esbuild-plugins Goto Github PK

This took me a while to pin down, but I have discovered that sometimes (specific types of error) messageText from TS diagnostics is not a string, it is actually an object with nesting:

{
    // ...stuff
    "start": 335,
    "length": 15,
    "code": 2322,
    "category": 1,
    "messageText": {
      "messageText": "Type '(thing: ThingInput) => Promise<{ thingName: string; thingId: string; }>' is not assignable to type 'EntityCreator<ThingInput>'.",
      "category": 1,
      "code": 2322,
      "next": [
        {
          "messageText": "Type 'Promise<{ thingName: string; thingId: string; }>' is not assignable to type 'Promise<NameAndId>'.",
          "category": 1,
          "code": 2322,
          "next": [
            {
              "messageText": "Type '{ thingName: string; thingId: string; }' is missing the following properties from type 'NameAndId': name, id",
              "category": 1,
              "code": 2739
            }
          ]
        }
      ]
    }
}

Because of this, this check in the worker means those diagnostics are not output in the errors array.

      if (typeof messageText !== "string")
        continue;

Notably the output key does have the error in since its not subject to these checks and the errorCount is correct.

I believe this could be fixed by using flattenDiagnosticMessageText

I just don't like empty lines in output.
Can you please check if msg.output is empty and skip console.error call if it is?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency @tsconfig/node16 to v16.1.3
• Update dependency @tsconfig/svelte to v5.0.4
• Update dependency @types/serve-static to v1.15.7
• Update dependency postcss to v8.4.38
• Update dependency unionfs to v4.5.4
• Update dependency @awesome-code-style/eslint-config to v5.1.0
• Update dependency @playwright/test to v1.42.1
• Update dependency eslint to v8.57.0
• Update dependency postcss-preset-env to v9.5.4
• Update dependency sass to v1.74.1
• Update dependency typescript to v5.4.3
• Update dependency vitest to v1.4.0
• Update mcr.microsoft.com/playwright Docker tag to v1.43.0
• Update typescript-eslint monorepo to v6.21.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency vite to v5.1.7 [SECURITY]
• Update dependency autoprefixer to v10.4.19
• Update dependency esbuild to v0.20.2
• Update dependency svelte-check to v3.6.9
• Update Node.js to v20.12.1
• Update dependency @babel/core to v7.24.4
• Update dependency @types/node to v20.12.4
• Update dependency enhanced-resolve to v5.16.0
• Update dependency js-beautify to v1.15.1
• Update dependency typedoc to ~0.25.0
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Should be enough just to bump the version:

The error overlay does not seem to appear, so far I haven't seen it any circumstance even when esbuild encounters an error. Is there any configuration that needs to be set for it to work?
I found that there's this package, but it seems that's only intended for using within esbuild-plugin-livereload.

Do you think there's something I'm doing wrong or could there be a bug that causes the error overlay not to appear?

The plugin '@jgoz/esbuild-plugin-html' reads the template file only once during plugin initialization. If the file changes, outdated data is processed in the OnEnd. I'm using esbuild in watch mode. It would be good if the template is always read from the disk in the OnEnd

First off, I'm loving the plugin, really nice job, but there's a problem, my build is always completed successfully even with type errors, I'd like to be able to catch the exception inside of catch so I can exit the build unsuccessfully.

well, no sure what happen, but I'm talking about esbuild-plugin-typecheck.

Edit: Another bug I just found is that is checking for files I didn't even include in the bundle... like it'd a normal cli tsc.