Problem with testing fldgen on developmental version of R about fldgen HOT 8 CLOSED

Is ncdf4 just not available yet for dev-r? I.e., is this a temporary, or potentially permanent, issue?

from fldgen.

I would hope that ncdf4 is just not available yet, I can't imagine they wouldn't update that package... however it is not that would be a major issue for fldgen and several other projects at the institute

from fldgen.

yeah, hopefully temporary. As far as i know, ncdf4 is one of the most widely used packages for using netcdfs in R. I cannot imagine it not being maintained and updated, hopefully in the not too distant future.

from fldgen.

yea hopefully we can add the dev test back soon because it catches things like this but if we are going to make the github actions tests requirements to merge PR I didn't want that to prevent PRs from being merged. @abigailsnyder if it looks like you can select specific github action tests as must pass to merge while excluding others then we could add it back in 🤷‍♀️

from fldgen.

@kdorheim done - we now block PRs from merging if they fail any test except the developmental version of R. So as you say, it's good to have it added back in because it lets us know what problems may be coming our way. So this way a PR can fail that test to warn us, but still be ok to merge if all the other tests pass.

from fldgen.

Looks like @abigailsnyder added specific PR merge requirements so can add the developmental version of R as a github actions test but that is low priority for the moment

from fldgen.

Nice 👏

from fldgen.

This test as been re-added because it will help us identify potential decency problems on the horizon.

from fldgen.