Comments (6)
Right now it does not look like we have access to the data needed for this test. It looks like it was something that might have been developed to run on a local test and it is unclear if there is a record about how the test data was generated. @crvernon, @FeralFlows, and @abigailsnyder do you think I could comment out this test for now to get the github actions up and running?
@kdorheim I think commenting it out so that we can see if there are any other errors to deal with on the github actions make sense, and then we can circle back to figuring this one out. I do think it's important that we figure it out (I know you do too), but whether we figure it out and then deal with github actions or deal with github actions and then figure it out...I don't think it matters too much
from fldgen.
Follow up notes:
The offending test is one making sure that results previously saved as .rda
agree with results saved as .rds
.
It's failing because the old .rda
data is not being carried anymore. We also never actually use the loadmodel
or savemodel
functions this test is for, so I'm stripping those functions and this test out of the code in an upcoming PR.
from fldgen.
Right now it does not look like we have access to the data needed for this test. It looks like it was something that might have been developed to run on a local test and it is unclear if there is a record about how the test data was generated. @crvernon, @FeralFlows, and @abigailsnyder do you think I could comment out this test for now to get the github actions up and running?
from fldgen.
error details (from Kalyn's machine and githubs test on a windows machine):
> test_check("fldgen")
-- 1. Error: reading and writing models works (@test_writedata.R#59) ----------
cannot open the connection
Backtrace:
1. testthat::expect_silent(testmodel1 <- loadmodel(oldfile, oldfmt = TRUE))
9. fldgen::loadmodel(oldfile, oldfmt = TRUE)
10. base::load(file)
11. base::readChar(con, 5L, useBytes = TRUE)
== testthat results ===========================================================
[ OK: 233 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
1. Error: reading and writing models works (@test_writedata.R#59)
Depending on what we figure out is causing the test failure, it's possible this may be related to missing data / weird vertical striping in results that @crvernon @FeralFlows are seeing. It may also be completely unrelated and just a test quirk due to updated packages at some point or something.
from fldgen.
Agree with @abigailsnyder
from fldgen.
@kdorheim I wonder if this error has anything with changes made in this commit
ab31dcf
might be worth checking when we do circle back to digging into the write test
from fldgen.
Related Issues (20)
- clean up comments and move internal functions in normalizeresiduals.R to be external HOT 1
- fix the memory bloat of a saved emulator HOT 6
- downsized data sets to speed up testing HOT 1
- Create and archive trained emulators for popular ESMs HOT 2
- Instructions in tutorial2 are incorrect
- Add option to splice a historical scenario onto each future scenario
- Meanfield arrays are not converted back to native units. HOT 1
- Misleading documentation in generate.TP.fullgrids
- Quantile transform sometimes generates NA values
- globalop field in griddata is incorrect when grid cells are missing
- Check with full GCM data - impacts of training on full data or just land data
- Add github actions to the repo HOT 2
- Add package down to fldgen HOT 1
- remove dependency on gcammaptools HOT 1
- Problem with testing fldgen on developmental version of R HOT 8
- update stickers on the readme HOT 1
- variability in Tgav and using Hector to drive trained ESM emulators HOT 1
- Add tutorials to actually go through emulator validation HOT 2
- revisit warnings - variable labels - units HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fldgen.