jftuga / ttlmap Goto Github PK

The All() method returns a direct reference to the internal map (m.m).

Any caller can then modify the map without acquiring the mutex, leading to potential race conditions.

Returning a deep map copy instead of a direct reference could be a solution.

I noticed a bug in ttlMap.Put(): the value is only set in the item.Value when the item is initially created, not on subsequent calls to Put with the same key.

package main

import (
	"fmt"
	"time"

	"github.com/jftuga/TtlMap"
)

func main() {
	tm := TtlMap.New[string](time.Second*4, 3, time.Second, true)
	defer tm.Close()

	tm.Put("example", "original")
	tm.Put("example", "revised")

	fmt.Printf("Example value is %s\n", tm.Get("example"))
	// Output:
	// Example value is original
}

Setting the value just needs to be moved out of the if !ok scope.

The goroutine started in the New function will run indefinitely. This could lead to resource leaks.

Suggestion: Add a Close or Stop method to signal the goroutine to stop.

Love the concept of this. Would love to see a feature that allowed an override of the default TTL so any item could have it's own custom TTL.