Please set the Java Tool chain in core/build.gradle about jediterm HOT 6 CLOSED

Also the Java Samples are misleading now.
Only the Kotlin JeditMain App works correctly on Linux + Java.

Would you like to receive a PR on both issues?

from jediterm.

@manticore-projects Thanks for spotting this. Fixed by 8372a7f

As for the Java Samples, I've just checked it on Windows and both com.jediterm.example.BasicTerminalExample / com.jediterm.example.BasicTerminalShellExample work for me. Could you please describe your problem with samples in a new issue first? (Yes, PR are always welcome.)

from jediterm.

Closed as fixed

from jediterm.

What I meant is:

1. the Kotlin Std. lib needs to be included, else the Resizing does not work (although there is no error message).

2. you deprecated some code which I found from the Kotlin example. But the Java example still shows the old, deprecated code.

from jediterm.

1. Yes, kotlin-stdlib:1.9.0 should be included by clients. Usually, it happens automatically as jediterm-core exposes its runtime dependencies in pom.xml.
2. If you meant UIUtil, I will update its usages, thanks for spotting. If it's something else, please share a link to deprecated code usage.

from jediterm.

1. Yes, kotlin-stdlib:1.9.0 should be included by clients. Usually, it happens automatically as jediterm-core exposes its runtime dependencies in pom.xml.

Correct, but this works only recently with the Maven Artifact.
Before I had to copy/link the local libraries and I skipped most (JNA, Logger etc.) because I had those in my own dependencies already.

Basically it's all about my bias: I though Kotlin compiles into Java Class and so would not be needed for the JAR files.
But since you are converting to Kotlin now, this assumption does not hold.

2. If you meant [UIUtil](https://github.com/JetBrains/jediterm/blob/a7670d96cfc65e49f5214750ec5259ca5a9f49eb/JediTerm/src/main/java/com/jediterm/example/BasicTerminalShellExample.java#L32), I will update its usages, thanks for spotting. If it's something else, please share a link to deprecated code usage.

Yes, this one exactly.

Thank you a lot for helping! Cheers!

from jediterm.