UserSettingsProvider#getSelectionColor() is called way too often about jediterm HOT 4 CLOSED

Do you mean com.jediterm.terminal.TerminalColor#myColorSupplier by providers/lambdas?
For example, here is now com.jediterm.terminal.ui.settings.UserSettingsProvider#getDefaultStyle is implemented in IntelliJ:

  @Override
  public TextStyle getDefaultStyle() {
    return new TextStyle(new TerminalColor(() -> AwtTransformers.fromAwtColor(myUiSettingsManager.getDefaultForeground())),
                         new TerminalColor(() -> AwtTransformers.fromAwtColor(myUiSettingsManager.getDefaultBackground())));
  }

So, everything works even if UserSettingsProvider#getDefaultStyle is called only once.
I agree with you there is some inconsistency. Probably, these methods should be called only once and dynamic colors should be supported via implementing Supplier<Color>.

from jediterm.

@pskowronek I tried to optimize it a bit in af3a61a, but generally, UserSettingsProvider#getSelectionColor() and UserSettingsProvider#getFoundPatternColor() could be called multiple times to support switching between different UI themes. I'd recommend to implement some caching in your UserSettingsProvider if these methods are expensive.

from jediterm.

Thanks! However, hmm, how does it differ from UserSettingsProvider#getDefaultStyle() - it is called once and probably providers/lambdas are called multiple times (which is fine), but UserSettingsProvider#getSelectionColor() is/was (need to check your change) called multiple of times even though they also return 'providers'.

from jediterm.

Do you mean com.jediterm.terminal.TerminalColor#myColorSupplier by providers/lambdas? For example, here is now com.jediterm.terminal.ui.settings.UserSettingsProvider#getDefaultStyle is implemented in IntelliJ:

yes, I haven't had a code in front of me.

So, everything works even if UserSettingsProvider#getDefaultStyle is called only once. I agree with you there is some inconsistency. Probably, these methods should be called only once and dynamic colors should be supported via implementing Supplier<Color>.

Yes, that was my thought.

from jediterm.