jessewilk / terraform Goto Github PK

Hi Jesse,

Not really an issue, just a suggestion. Also a thank you, your TF helped me a fix an underlying issue I was having and purely came across this by chance! Nice work

Your vault tf has a characteristic I just did some work around, thought I would share. I have a ACL list on my vault that are long, including certain networks and certain subnets. The var the virtual_network_subnet_ids accept is a bit meh. So I decided to write some data and loops around it using TF0.12

Starting with a data with a foreach

data "azurerm_subnet" "dev_sns" {
  for_each = toset(var.dev_subnets)
  name                 = each.value
  virtual_network_name = "pfs-dev-core-vn"
  resource_group_name  = "pfs-dev-core-rg"
}

then hit the problem of getting this into the block. Eventually found the solution using a for_each

virtual_network_subnet_ids  = concat(
    [for subnet in data.azurerm_subnet.dev_sns : subnet.id],
    [for subnet in data.azurerm_subnet.prod_sns : subnet.id],
    [for subnet in data.azurerm_subnet.prodacc_sns : subnet.id],
    [for subnet in data.azurerm_subnet.stage_sns : subnet.id],

  )

Works pretty nicely, allowing you to map into multiple different subnets and vnets. Maybe of some use!

Thanks again for sharing your code.

Rich