jessecoretta / go-aci Goto Github PK

Request

I would like to see the code coverage grade maintained at no less than 80% of the sum line total within this SDK. Higher coverage would be especially appreciated.

unify redundant blocks. reference T/B DN technique

Following append of AttributeFilterOperation to AttributeFilterOperations (via Push() method), the Operation identifier (add= and delete=) is missing. This does not occur during manual execution of AttributeFilterOperation.String(), thus it may be a go-stackage issue.

Workaround: use private PresentationPolicy, pass executed policy as raw string to SetExpression during TargetRule/BindRule creation. I want to preserve the proper type (AttributeFilterOperation) and not rely on this workaround for too long.

Investigate.

Request

To remain in line with the relevant comment in the documentation, the following files need to be reworked to bring their respective cyclomatic factors down to no greater than nine (9):

• rules.go
• ldap.go
• rights.go

I would like to streamline the keyword verification logic to reduce the need for (internal) type assertion considerably. I would also like to tie the verifications into specific types, which also reduces the need for interrogation of interface values.

Overall, the collective code representing the keyword logic could have a considerably smaller footprint, which would be desirable in the long-term.

The README.md format is far more flexible in terms of content features and markdown than as compared to Go's native formatting. Additionally, since Go's pkgsite framework will render the README.md for the visitor automatically, there need only be one copy.

Move the entirety of doc.go into README.md, clean-up formatting, add images and get rid of doc.go.

This is just a to-do note for me. Fix this issue.

    time_test.go:235: TestToD failed: General timeofday error: parsing time "2400": hour out of range

This issue is sporadic ... succeeding 99% of the time, and throwing the above error %1 of the time. There is actually no problem per se, but my attempt to find a balance between an input ACI clock time of 2400 and the conversion to a Go clock time of 2359 seems to have failed.

Try again.

Request

Here are some ideas for _example/main.go-type demo executables to be offered within this repository:

• ACI Analyzer - suggest using rivo/tview due to its overwhelming coolness
• ACI Diagram Generator - suggest using goccy/go-graphviz due to widespread adoption of graphviz in general
• Various text/template "stubs" with simple demo
• Convenience wrapper func examples (i.e.: helper functions the user is expected to write to suit their needs), such as:
  • DN naming context helper (avoid typos, more convenient (faster!) reference to DNs versus string literals)
  • "Controlled" ACI generator (func to accept only the arguments desired by an organization's ACI "policy")

Combine Day, Level and Right bitshifting logic to greatly reduce footprint and potential pain points