jerrylow / breakpoints Goto Github PK

Hello!
I just realized your code give an error on ie11 on line 211.
It turns out ie11 does not support "includes" method.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes

My Suggestion.

change this:
} else if (compareMethods.includes(method)) {
to this:
} else if (compareMethods.indexOf(method) >= 0) {

thanks

So, I'm trying this plugin and from what I can see the width of the breakpoint settings are not correct if there is a scrollbar present.

If I have the following settings on a page with a scrollbar:

breakpoints: [{
    "name": "tablet",
        "width": 768 //will actually detect breakpoint at 785
    }, {
        "name": "desktop",
        "width": 1024 //will actually detect breakpoint at 1041
    }]