cs4500_project's People
Forkers
mwaldrichcs4500_project's Issues
Issues with tests on `TestUpdates` branch
We did our implementation based on your previous API with two separate string and object queues.
I would like to open a pull request to update the tests on the TestUpdates
branch to address some of the problems with you old test suite:
- Segfault when
delete string3
. - A bunch of redeclaration issues for
popped
on lines 84-96.
Would it be possible to add me as a contributor, so I can open a pull request to update that branch?
If not would it be possible to furnish those fixes? I believe they have already been fixed for the version on master.
Change tests to reflect updated Queue class
#12 asks to change the tests. I know the other team isn't using the current Queue class, but our team is, and if you're going to merge the changes to the Queue class to create only 1 class, then the tests should be updated to reflect these changes. Otherwise revert the changes and we'll implement the original design.
There is nothing about the Piazza post mentioned in #12 that refers to Queue. The Array changes were suggested because the spec says they need to support primitive types as well. However, nothing about the spec suggests that primitive types need to be supported in Queue, or that Queues must be strongly typed, so that's why we suggested reducing code duplication by creating only 1 Queue class for Objects. We would rather not overcomplicate things and stick with the current design.
But again, regardless, tests should match the current API in the repo. So either the current API needs to be reverted or the tests need to be changed.
Thanks
Change tests to reflect your updated Queue class
Please change your tests so that our code compiles
object_queue_normal_usage() and object_queue_advanced_usage() -- should the tests be Objects?
Some of the tests in these functions compare Strings when they should be comparing Objects.
APIs to implement
These repositories contain the APIs you should implement
- Queue
https://github.com/austenke/a1-part2.git
- Map
https://github.com/kachmarma/cs4500-a1-p2.git
- Array
include assert in test file.
You need to #include<assert.h> in the test-queue.cpp
Would you consider renaming your size() function?
for some reason the compiler throws this error when I try to compile code with a call to size(): "expression preceding parentheses of apparent call must have (pointer-to-) function type".
would you consider renaming it to get_size() or something?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.