jeremycollake / groupextend Goto Github PK

May not be desirable.

Dedicated thread for enumeration.

Default process group needs detected by NT Native API, else can result in improper thread distribution when it doesn't realize thread needs moved. Assumption of first group in GetProcessGroupAffinity is invalid (returned array is sorted numerically).

Process Lasso already adapted at of 9.8.1.13 beta.

Excess compute was found at loop iterating over returned ToolHelp snapshot with Thread32First/Next. Thread32Next never returns FALSE, never finding the end of the snapshot, and therefore continuing indefinitely, consuming all compute available to that thread.

Preliminary analysis:
Cause is previously unknown ToolHelp API thread-safety quirk, despite each thread obtaining distinct snapshots.

Description:
When a thread obtains and iterates on a snapshot, while another thread obtains and iterates on a new/distinct snapshot, the First/Next API loop in both threads may continue indefinitely. Although the root cause is still unclear, the ToolHelp API may not be as thread-safe as purported.

Possibility of reentrancy issue into thread requesting the snapshot was eliminated.

Default process group needs detected by NT Native API, else can result in improper thread distribution when it doesn't realize thread needs moved. Assumption that default is first item in returned GetProcessGroupAffinity array is invalid (returned array is sorted numerically).