Giter Club home page Giter Club logo

adventofcode2023's People

Contributors

jeffstevens98 avatar sleepicaffeine avatar

Stargazers

CaptainD1 avatar

Watchers

avatar

Forkers

sleepicaffeine

adventofcode2023's Issues

A few safety and usage issues

Personal Message:

Heya, I was scrolling through Reddit and saw your submission for day 1. I really like the way you approached it, its surprisingly simple and easy to understand!
Having said that, I did notice some issues in your code, mainly stuff about how you did some things in a roundabout way or some nitpicky safety stuff.

Actual Issues
  • Usage of the [] access modifiers when .at() is avaibale
  • Despite warning the user when the file fails to open, there is no exit() or abort() or throw ... to exit the program
  • findCalibrationValueSum_v2 does not even do the file check, and doesn't even print the result
Nitpicks
  • Some of your variables aren't super readable. I would advise moving them closer to the loops or even inside the loops (compilers nowadays are smart enough to optimize that).
  • Using built-in initializers like std::basic_ifstream(const char *__s) or std::vector(std::size_t __n, const std::allocator<int> &__a) instead of relying on additional overhead like <algotithm>'s std::fill()
  • Loops where you count sum are redundant
  • Replacing std::map with std::unordered_map could net you a slight speed bonus, as the benefits of std::map are not needed

For this being your first year, I highly encourage you to keep going! No solution is bad if it gives you the desired result!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.