Giter Club home page Giter Club logo

withable's People

Contributors

jedrzej avatar jedrzej-x-team-com avatar pablomaurer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

withable's Issues

Scope not applied on SQL query

class User extends Authenticatable
{
    use PimpableTrait;

    public function profiles()
    {
        return $this->morphMany(Profile::class, 'relation');
    }
}

class Profile extends BaseModel
{
    use PimpableTrait;

    public function relation()
    {
        return $this->morphTo();
    }

    public function scopeDefault()
    {
        return $this->where('default', 1);
    }
}

Query:

/users/1?with=profiles:default

SQL Query being created:

SELECT * 
FROM   `profiles` 
WHERE  `profiles`.`relation_id` IN ( '1' ) 
       AND `profiles`.`relation_type` = 'App\\User' 

Should be:

SELECT * 
FROM   `profiles` 
WHERE  `profiles`.`default` = 1 
       AND `profiles`.`relation_id` IN ( '1' ) 
       AND `profiles`.`relation_type` = 'App\\User' 

Support for scopes

It would be great to have support for scopes on related models.

Something like with=projects:closed

scopes on related models conflicts with Eager Loading Specific Columns

The character used to separate scope by the relationship conflicts with Laravel's mechanism to select only specific columns from the relationships.

For example:
"with=projects:closed" don't allow to select only id, title, description from that relationship like "with=projects:id,title,description"

A quick fix is maybe to change the separator character for relationships scopes.

"projects:id,title,description#closed"

This example will still work with specific columns selection and scope calling.

Do you have any better idea?

Integration with Dingo

How can we integrate it woth Fractral Transformers? I'm working with Dingo for response API requests.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.