jdrago999 / aws-s3 Goto Github PK

There are critical hash ordering bugs in this distribution's modules with the use of perl 5.18 and above. I have added a test case in my fork, which shows bugs in the Signer module, the commit message describes the issue:

96b6b1b

The test failure is typical of hash/load order bugs. It sporadically fails with 5.18 but passes with 5.16. The bug may be caused by the fact that some attributes depend on others but not all are lazy.

I have also noticed that some of the attributes have rather odd definitions in that they are required => 1 but also lazy => 1 and have a default. This is a contradiction in all but the narrowest use case (required+lazy+default can make sense for an attribute which has a clearer).

I will look into fixing this in my branch and raise a pull-request if necessary. I would say in its current state the distribution is broken with 5.18+ as the Signer module will not always correctly sign the request.

Been running into an issue while accessing an object that is zero bytes. Here is the error returned.

Attribute (size) does not pass the type constraint because: Validation failed for 'Int' with value undef at constructor AWS::S3::File::new (defined at /usr/local/share/perl/5.14.2/AWS/S3/File.pm line 195) line 106
AWS::S3::File::new('AWS::S3::File', 'bucket', 'AWS::S3::Bucket=HASH(0x3112b80)', 'key', 'cases/00398535/a0i30000001ClJcAAK/Status.html', 'size', undef, 'contenttype', 'application/octet-stream', 'etag', '"d41d8cd98f00b204e9800998ecf8427e"', 'lastmodified', 'Fri, 13 Mar 2015 01:06:04 GMT', 'is_encrypted', 0) called at /usr/local/share/perl/5.14.2/AWS/S3/Bucket.pm line 181
AWS::S3::Bucket::file('AWS::S3::Bucket=HASH(0x3112b80)', 'cases/00398535/a0i30000001ClJcAAK/Status.html') called at lib/s3.pm line 64
s3::getObj('s3=HASH(0x2ab3000)', 'cases/00398535/a0i30000001ClJcAAK/Status.html') called at obj-bak.pl line 473

As VSO is deprecated in favour if Mouse/Mouse, would it be possible to move to Moose?
If you agree, I can write the patch.

I highlighted some of them robin13@933e0ef

The test now errors with

 Can't locate object method "contenttype" via package "AWS::S3::File" at t/010-basic/010-basic.t line 215.
 at t/010-basic/010-basic.t line 215

It appears as if this patch

1. cuddles the elses
2. renames some occurances of contenttype to content_type while leaving others untouched
3. fails tests because of references to older "contenttype" and not new "content_type"

"contenttype" occurs in lib/AWS/S3/HTTPRequest.pm and lib/AWS/S3/Bucket.pm -- neither of these occurances were changed either.