jdennes / contribution-checker Goto Github PK

The following documented criterion is missing from the or_criteria in the check results:

"You have opened a pull request or issue in the repository."

The check result appears to be reporting the "Have you starred the repository containing the commit?" incorrectly:

Commit: campaignmonitor/createsend-perl@5d0a41a

I have starred this: https://github.com/campaignmonitor/createsend-perl

Currently, the checker will report that a commit should be counted if the commit author has added a generic email address like [email protected] to their GitHub account (even though the address won't be used for commit attribution).

Ideally, it shouldn't. GitHub detects "generic" email addresses, which we should do here too.